All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: chandan <chandan@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com,
	sekharan@linux.vnet.ibm.com
Subject: Re: [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096
Date: Mon, 26 Aug 2013 09:29:31 -0500	[thread overview]
Message-ID: <521B664B.7030404@redhat.com> (raw)
In-Reply-To: <44437668.FEX1DiRokR@localhost.localdomain>

On 8/26/13 12:38 AM, chandan wrote:
> On Sunday, August 25, 2013 11:54:30 AM Eric Sandeen wrote:
>> Can you explain why this is necessary?
>>
>> What failures do you see, on what filesystems?
> 
> generic/255 currently fails on Btrfs on a ppc64 machine with 64k page size and
> hence 64k block size.
> 
> generic/255 has been written to test the corner cases for 4k block size. I did
> try to make it work with variable sized block sizes, But I got stuck
> working with md5sum (since we would need two sets of md5sums, due to
> _test_generic_punch() being invoked with and without '-k' option per block
> size). 
> 
> Since 4k block size support for Btrfs on ppc64 is already being worked on, I
> think its better to prevent execution of generic/255 for block sizes greater
> than 4k.
> 
> Apologies for not including the above description in the patch.

It happens.  ;)

To be honest I haven't really looked at how _test_generic_punch & generic/255
works lately.

Just as a sanity check, does it also fail on xfs for 64k block sizes on ppc64?

Thanks,
-Eric


WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com>
To: chandan <chandan@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	sekharan@linux.vnet.ibm.com, linux-btrfs@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096
Date: Mon, 26 Aug 2013 09:29:31 -0500	[thread overview]
Message-ID: <521B664B.7030404@redhat.com> (raw)
In-Reply-To: <44437668.FEX1DiRokR@localhost.localdomain>

On 8/26/13 12:38 AM, chandan wrote:
> On Sunday, August 25, 2013 11:54:30 AM Eric Sandeen wrote:
>> Can you explain why this is necessary?
>>
>> What failures do you see, on what filesystems?
> 
> generic/255 currently fails on Btrfs on a ppc64 machine with 64k page size and
> hence 64k block size.
> 
> generic/255 has been written to test the corner cases for 4k block size. I did
> try to make it work with variable sized block sizes, But I got stuck
> working with md5sum (since we would need two sets of md5sums, due to
> _test_generic_punch() being invoked with and without '-k' option per block
> size). 
> 
> Since 4k block size support for Btrfs on ppc64 is already being worked on, I
> think its better to prevent execution of generic/255 for block sizes greater
> than 4k.
> 
> Apologies for not including the above description in the patch.

It happens.  ;)

To be honest I haven't really looked at how _test_generic_punch & generic/255
works lately.

Just as a sanity check, does it also fail on xfs for 64k block sizes on ppc64?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-08-26 14:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-25 15:06 [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096 chandan
2013-08-25 15:06 ` chandan
2013-08-25 16:54 ` Eric Sandeen
2013-08-25 16:54   ` Eric Sandeen
2013-08-26  5:38   ` chandan
2013-08-26  5:38     ` chandan
2013-08-26 14:29     ` Eric Sandeen [this message]
2013-08-26 14:29       ` Eric Sandeen
2013-08-27 12:16       ` chandan
2013-08-27 12:16         ` chandan
2013-08-27 16:46         ` Eric Sandeen
2013-08-28  8:14           ` chandan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521B664B.7030404@redhat.com \
    --to=sandeen@redhat.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=sekharan@linux.vnet.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.