Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic

["Andreas Färber" <afaerber@suse.de>]

Am 26.08.2013 14:21, schrieb Paolo Bonzini:
> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>> vapic requires the VAPIC ROM to be mapped into RAM.  This is not
>> possible without PAM hardware.  This fixes a segmentation fault
>> running with -M isapc.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index a19e172..3aa244a 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>      .init = pc_init_isa,
>>      .max_cpus = 1,
>>      .compat_props = (GlobalProperty[]) {
>> +        {
>> +            .driver   = "apic-common",
>> +            .property = "kvmvapic",
>> +            .value    = "off",
>> +        },
>>          { /* end of list */ }
>>      },
>>      DEFAULT_MACHINE_OPTIONS,
>>
> 
> Ping.

I had double-checked that my pending qom-test covers isapc and succeeds
with and without your patch, so apparently this is visible at runtime only.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg