gdbstub fails to compile

gdbstub fails to compile

[Olaf Hering]

In current xen-unstable xen/commons/gdbstub.c fails to compile:

 gdbstub.c: In function '__trap_to_gdb':
 gdbstub.c:610:5: error: implicit declaration of function 'watchdog_disable' [-Werror=implicit-function-declaration]
 gdbstub.c:610:5: error: nested extern declaration of 'watchdog_disable' [-Werror=nested-externs]
 gdbstub.c:636:5: error: implicit declaration of function 'watchdog_enable' [-Werror=implicit-function-declaration]
 gdbstub.c:636:5: error: nested extern declaration of 'watchdog_enable' [-Werror=nested-externs]

Its the first time I compile xen-unstable since 4.3.0, so I cant tell when this
error was introduced. I see watchdog_enable is called from a few places, so its
maybe just a missing include.

Olaf

Re: gdbstub fails to compile

[Andrew Cooper]

On 26/08/2013 20:44, Olaf Hering wrote:
> In current xen-unstable xen/commons/gdbstub.c fails to compile:
>
>  gdbstub.c: In function '__trap_to_gdb':
>  gdbstub.c:610:5: error: implicit declaration of function 'watchdog_disable' [-Werror=implicit-function-declaration]
>  gdbstub.c:610:5: error: nested extern declaration of 'watchdog_disable' [-Werror=nested-externs]
>  gdbstub.c:636:5: error: implicit declaration of function 'watchdog_enable' [-Werror=implicit-function-declaration]
>  gdbstub.c:636:5: error: nested extern declaration of 'watchdog_enable' [-Werror=nested-externs]
>
> Its the first time I compile xen-unstable since 4.3.0, so I cant tell when this
> error was introduced. I see watchdog_enable is called from a few places, so its
> maybe just a missing include.
>
> Olaf

That would be my fault (and very recently).  Patch on its way.

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

[PATCH] xen/gdb: Fix gdbstub build c/s c8177e691f

[Andrew Cooper]

That changeset moved the watchdog functions from nmi.h to their own
watchdog.h.  I thought I had updated all relevant header files and the
compiler was happy as well.  However, gdbstub is not even compiled by default,
and I accidentally missed it.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Olaf Hering <olaf@aepfle.de>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/common/gdbstub.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c
index 2baa91a..67ff726 100644
--- a/xen/common/gdbstub.c
+++ b/xen/common/gdbstub.c
@@ -38,7 +38,7 @@
 #include <xen/spinlock.h>
 #include <xen/serial.h>
 #include <xen/irq.h>
-#include <xen/nmi.h>
+#include <xen/watchdog.h>
 #include <asm/debugger.h>
 #include <xen/init.h>
 #include <xen/smp.h>
-- 
1.7.10.4