From: Stephen Warren <swarren@wwwdotorg.org>
To: Xiubo Li-B47053 <B47053@freescale.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Guo Shawn-R65073 <r65073@freescale.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"rob@landley.net" <rob@landley.net>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM
Date: Mon, 26 Aug 2013 14:01:17 -0600 [thread overview]
Message-ID: <521BB40D.7040001@wwwdotorg.org> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F827E11AC@039-SN2MPN1-012.039d.mgd.msft.net>
On 08/25/2013 11:35 PM, Xiubo Li-B47053 wrote:
>> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for
...
>>> Why do you need to manipulate the pinctrl to en/disable a channel?
>>
>> This is because in Vybrid VF610 TOWER board, there are 4 leds, and each
>> led's one point(diode's positive pole) is connected to 3.3V, and the
>> other point is connected to pwm's one channel. When the 4 pinctrls are
>> configured as enable at the same time, the 4 pinctrls is low valtage, and
>> the 4 leds will be lighted up as default, then when you enable/disable
>> one led will effects others.
>>
>> These pinctrls are belong to pwm, and I don't think led or other customer
>> could control them directly.
>> So, here I authorize the 4 pinctrls to each channel controls.
>>
> "
> For the reason above, I have to control the pinctrls separately.
>
> If all the pinctrls set as default state, the 8 pinctrls must be controlled together.
> And the 4 leds will all be lighted up as default and will influence each other.
Sorry, that still doesn't make much sense. Either way though, having
separate pinctrl setup for a single device isn't going to work. You'll
either need to have all combinations of 4 (8?) PWMs represented as
pinctrl states(!), or register separate PWM devices so that they get
independant pinctrl states.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM
Date: Mon, 26 Aug 2013 14:01:17 -0600 [thread overview]
Message-ID: <521BB40D.7040001@wwwdotorg.org> (raw)
In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F827E11AC@039-SN2MPN1-012.039d.mgd.msft.net>
On 08/25/2013 11:35 PM, Xiubo Li-B47053 wrote:
>> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for
...
>>> Why do you need to manipulate the pinctrl to en/disable a channel?
>>
>> This is because in Vybrid VF610 TOWER board, there are 4 leds, and each
>> led's one point(diode's positive pole) is connected to 3.3V, and the
>> other point is connected to pwm's one channel. When the 4 pinctrls are
>> configured as enable at the same time, the 4 pinctrls is low valtage, and
>> the 4 leds will be lighted up as default, then when you enable/disable
>> one led will effects others.
>>
>> These pinctrls are belong to pwm, and I don't think led or other customer
>> could control them directly.
>> So, here I authorize the 4 pinctrls to each channel controls.
>>
> "
> For the reason above, I have to control the pinctrls separately.
>
> If all the pinctrls set as default state, the 8 pinctrls must be controlled together.
> And the 4 leds will all be lighted up as default and will influence each other.
Sorry, that still doesn't make much sense. Either way though, having
separate pinctrl setup for a single device isn't going to work. You'll
either need to have all combinations of 4 (8?) PWMs represented as
pinctrl states(!), or register separate PWM devices so that they get
independant pinctrl states.
next prev parent reply other threads:[~2013-08-26 20:01 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 3:07 [PATCH 0/4] Add freescale ftm pwm driver for Vybrid VF610 TOWER Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` [PATCH 1/4] pwm: add freescale ftm pwm driver support Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 7:36 ` Sascha Hauer
2013-08-21 7:36 ` Sascha Hauer
2013-08-21 9:24 ` Xiubo Li-B47053
2013-08-21 9:24 ` Xiubo Li-B47053
2013-08-21 9:50 ` Sascha Hauer
2013-08-21 9:50 ` Sascha Hauer
2013-08-21 10:46 ` Xiubo Li-B47053
2013-08-21 10:46 ` Xiubo Li-B47053
2013-08-23 7:58 ` Thierry Reding
2013-08-23 7:58 ` Thierry Reding
2013-08-23 9:05 ` Thierry Reding
2013-08-23 9:05 ` Thierry Reding
2013-08-26 7:32 ` Xiubo Li-B47053
2013-08-26 7:32 ` Xiubo Li-B47053
2013-08-27 7:40 ` Thierry Reding
2013-08-27 7:40 ` Thierry Reding
2013-08-27 9:56 ` Xiubo Li-B47053
2013-08-27 9:56 ` Xiubo Li-B47053
2013-08-21 3:07 ` [PATCH 2/4] ARM: dts: Add Freescale ftm pwm node for VF610 Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-23 9:13 ` Thierry Reding
2013-08-23 9:13 ` Thierry Reding
2013-08-26 5:58 ` Xiubo Li-B47053
2013-08-26 5:58 ` Xiubo Li-B47053
2013-08-26 5:58 ` Xiubo Li-B47053
2013-08-21 3:07 ` [PATCH 3/4] ARM: dts: Enables ftm pwm device for Vybrid VF610 TOWER board Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-23 9:13 ` Thierry Reding
2013-08-23 9:13 ` Thierry Reding
2013-08-26 6:00 ` Xiubo Li-B47053
2013-08-26 6:00 ` Xiubo Li-B47053
2013-08-21 3:07 ` [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 3:07 ` Xiubo Li
2013-08-21 19:30 ` Tomasz Figa
2013-08-21 19:30 ` Tomasz Figa
2013-08-22 2:55 ` Xiubo Li-B47053
2013-08-22 2:55 ` Xiubo Li-B47053
2013-08-22 6:26 ` Sascha Hauer
2013-08-22 6:26 ` Sascha Hauer
2013-08-22 7:32 ` Xiubo Li-B47053
2013-08-22 7:32 ` Xiubo Li-B47053
2013-08-23 7:36 ` Thierry Reding
2013-08-23 7:36 ` Thierry Reding
2013-08-23 19:29 ` Stephen Warren
2013-08-23 19:29 ` Stephen Warren
2013-08-26 5:35 ` Xiubo Li-B47053
2013-08-26 5:35 ` Xiubo Li-B47053
2013-08-26 20:01 ` Stephen Warren [this message]
2013-08-26 20:01 ` Stephen Warren
2013-08-27 3:48 ` Xiubo Li-B47053
2013-08-27 3:48 ` Xiubo Li-B47053
2013-08-27 4:04 ` Stephen Warren
2013-08-27 4:04 ` Stephen Warren
2013-08-26 5:46 ` Xiubo Li-B47053
2013-08-26 5:46 ` Xiubo Li-B47053
2013-08-22 8:25 ` Tomasz Figa
2013-08-22 8:25 ` Tomasz Figa
2013-08-22 9:52 ` Xiubo Li-B47053
2013-08-22 9:52 ` Xiubo Li-B47053
2013-08-22 12:17 ` Tomasz Figa
2013-08-22 12:17 ` Tomasz Figa
2013-08-22 12:17 ` Tomasz Figa
2013-08-23 8:04 ` Thierry Reding
2013-08-23 8:04 ` Thierry Reding
2013-08-23 9:10 ` Thierry Reding
2013-08-23 9:10 ` Thierry Reding
2013-08-23 19:36 ` Stephen Warren
2013-08-23 19:36 ` Stephen Warren
2013-08-30 19:19 ` Kumar Gala
2013-08-30 19:19 ` Kumar Gala
2013-08-30 19:19 ` Kumar Gala
2013-08-30 20:11 ` Stephen Warren
2013-08-30 20:11 ` Stephen Warren
2013-09-03 5:25 ` Xiubo Li-B47053
2013-09-03 5:25 ` Xiubo Li-B47053
2013-09-02 2:18 ` Xiubo Li-B47053
2013-09-02 2:18 ` Xiubo Li-B47053
2013-09-02 2:18 ` Xiubo Li-B47053
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521BB40D.7040001@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=B47053@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=r65073@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=thierry.reding@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.