[PATCH 1/1] consolekit_0.4.6.bb: Fix QA error when --enable-udev-acl

[PATCH 1/1] consolekit_0.4.6.bb: Fix QA error when --enable-udev-acl

[leimaohui]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Add EXTRA_OECONF += "--enable-udev-acl" to 

consolekit_0.4.6.bb whill cause a package_qa error. 

The error message looks like:

 

| ERROR: QA Issue: non debug package contains .debug directory: 

| consolekit path consolekit/0.4.6-r0/packages-split/consolekit/lib/u

| dev/.debug/udev-acl

 

There is a need to add udev-acl file to package instead of "${base_libdir}"

 

Signed-off-by: leimaohui <leimaohui@cn.fujitsu.com>

---

diff --git a/meta/recipes-support/consolekit/consolekit_0.4.6.bb 

b/meta/recipes-support/consolekit/consolekit_0.4.6.bb

index 63da028..4133f4d 100644

--- a/meta/recipes-support/consolekit/consolekit_0.4.6.bb

+++ b/meta/recipes-support/consolekit/consolekit_0.4.6.bb

@@ -28,9 +28,10 @@ PACKAGECONFIG[policykit] = ",,polkit"

PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=

${systemd_unitdir}/system/,--with-systemdsystemunitdir="

 

FILES_${PN} += "${localstatedir}/log/ConsoleKit ${exec_prefix}/lib/ConsoleKit \

-                ${libdir}/ConsoleKit  ${systemd_unitdir} ${base_libdir} \

-                ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"

-FILES_${PN}-dbg += "${base_libdir}/security/.debug"

+                ${libdir}/ConsoleKit  ${systemd_unitdir}
${base_libdir}/udev/rules.d \

+               ${base_libdir}/udev/udev-acl ${datadir}/dbus-1
${datadir}/PolicyKit \

+               ${datadir}/polkit*"

+FILES_${PN}-dbg += "${base_libdir}/security/.debug /lib/udev/.debug"

 

PACKAGES =+ "pam-plugin-ck-connector"

FILES_pam-plugin-ck-connector += "${base_libdir}/security/*.so"

--

1.7.1

 


[-- Attachment #2: Type: text/html, Size: 8481 bytes --]

Re: [PATCH 1/1] consolekit_0.4.6.bb: Fix QA error when --enable-udev-acl

[Saul Wold]

On 08/27/2013 12:10 AM, leimaohui wrote:
> Add EXTRA_OECONF += "--enable-udev-acl" to
>
> consolekit_0.4.6.bb whill causea package_qa error.
>
> The error message looks like:
>
> |ERROR: QA Issue: non debug package contains .debug directory:
>
> | consolekit path consolekit/0.4.6-r0/packages-split/consolekit/lib/u
>
> | dev/.debug/udev-acl
>
> There is a need to add udev-acl file to package instead of “${base_libdir}”
>
> Signed-off-by: leimaohui <leimaohui@cn.fujitsu.com
> <mailto:leimaohui@cn.fujitsu.com>>
>
> ---
>
> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.6.bb
>
> b/meta/recipes-support/consolekit/consolekit_0.4.6.bb
>
> index 63da028..4133f4d 100644
>
> --- a/meta/recipes-support/consolekit/consolekit_0.4.6.bb
>
> +++ b/meta/recipes-support/consolekit/consolekit_0.4.6.bb
>
> @@ -28,9 +28,10 @@ PACKAGECONFIG[policykit] = ",,polkit"
>
> PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=
>
> ${systemd_unitdir}/system/,--with-systemdsystemunitdir="
>
> FILES_${PN} += "${localstatedir}/log/ConsoleKit
> ${exec_prefix}/lib/ConsoleKit \
>
> -                ${libdir}/ConsoleKit  ${systemd_unitdir} ${base_libdir} \
>
> -                ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>
> -FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>
> +                ${libdir}/ConsoleKit  ${systemd_unitdir}
> ${base_libdir}/udev/rules.d \
>
> +               ${base_libdir}/udev/udev-acl ${datadir}/dbus-1
> ${datadir}/PolicyKit \
>
> +               ${datadir}/polkit*"
>
> +FILES_${PN}-dbg += "${base_libdir}/security/.debug /lib/udev/.debug"
>
Please use ${base_libdir} instead of /lib here.

Thanks
	Sau!

> PACKAGES =+ "pam-plugin-ck-connector"
>
> FILES_pam-plugin-ck-connector += "${base_libdir}/security/*.so"
>
> --
>
> 1.7.1
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH 1/1] consolekit_0.4.6.bb: Fix QA error when --enable-udev-acl

[Phil Blundell]

On Tue, 2013-08-27 at 08:16 -0700, Saul Wold wrote:
> On 08/27/2013 12:10 AM, leimaohui wrote:
> > -FILES_${PN}-dbg += "${base_libdir}/security/.debug"
> >
> > +                ${libdir}/ConsoleKit  ${systemd_unitdir}
> > ${base_libdir}/udev/rules.d \
> >
> > +               ${base_libdir}/udev/udev-acl ${datadir}/dbus-1
> > ${datadir}/PolicyKit \
> >
> > +               ${datadir}/polkit*"
> >
> > +FILES_${PN}-dbg += "${base_libdir}/security/.debug /lib/udev/.debug"

> Please use ${base_libdir} instead of /lib here.

Really?  Hard-coding /lib isn't all that great but I think
${base_libdir} would be even more wrong.  Shouldn't it be
${nonarch_base_libdir}?

p.