All of lore.kernel.org
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/9] watchdog: orion: Update device-tree binding documentation
Date: Tue, 27 Aug 2013 15:44:41 -0600	[thread overview]
Message-ID: <521D1DC9.5040409@wwwdotorg.org> (raw)
In-Reply-To: <20130827083603.GA2286@localhost>

On 08/27/2013 02:36 AM, Ezequiel Garcia wrote:
> On Mon, Aug 26, 2013 at 10:08:43AM -0400, Jason Cooper wrote:
>> On Fri, Aug 23, 2013 at 07:12:20PM -0300, Ezequiel Garcia wrote:
>>> Change the 'reg' property meaning, by defining two required cells.
>>> It's important to note this commit breaks DT-compatibility for this
>>> device.
>>>
>>> Cc: devicetree at vger.kernel.org
>>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>>> ---
>>>  Documentation/devicetree/bindings/watchdog/orion-wdt.txt | 7 +++++--
>>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> index 5dc8d30..a74c9c8 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> @@ -3,7 +3,9 @@
>>>  Required Properties:
>>>  
>>>  - Compatibility : "marvell,orion-wdt"
>>> -- reg		: Address of the timer registers
>>> +- reg		: Two cells are required:
>>> +		  First  cell contains the global timer control register.
>>> +		  Second cell contains the watchdog counter register.

BTW, you don't have 2 cells here, but 4 cells (assuming typical
#address-cells and #size-cells values). Instead, you have 2 register
specifiers.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	devicetree@vger.kernel.org, wim@iguana.be,
	Gregory Clement <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 7/9] watchdog: orion: Update device-tree binding documentation
Date: Tue, 27 Aug 2013 15:44:41 -0600	[thread overview]
Message-ID: <521D1DC9.5040409@wwwdotorg.org> (raw)
In-Reply-To: <20130827083603.GA2286@localhost>

On 08/27/2013 02:36 AM, Ezequiel Garcia wrote:
> On Mon, Aug 26, 2013 at 10:08:43AM -0400, Jason Cooper wrote:
>> On Fri, Aug 23, 2013 at 07:12:20PM -0300, Ezequiel Garcia wrote:
>>> Change the 'reg' property meaning, by defining two required cells.
>>> It's important to note this commit breaks DT-compatibility for this
>>> device.
>>>
>>> Cc: devicetree@vger.kernel.org
>>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>>> ---
>>>  Documentation/devicetree/bindings/watchdog/orion-wdt.txt | 7 +++++--
>>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> index 5dc8d30..a74c9c8 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/orion-wdt.txt
>>> @@ -3,7 +3,9 @@
>>>  Required Properties:
>>>  
>>>  - Compatibility : "marvell,orion-wdt"
>>> -- reg		: Address of the timer registers
>>> +- reg		: Two cells are required:
>>> +		  First  cell contains the global timer control register.
>>> +		  Second cell contains the watchdog counter register.

BTW, you don't have 2 cells here, but 4 cells (assuming typical
#address-cells and #size-cells values). Instead, you have 2 register
specifiers.

  parent reply	other threads:[~2013-08-27 21:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 22:12 [PATCH v2 0/9] Orion watchdog DT changes to support more SoCs Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 1/9] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 2/9] watchdog: orion: Make counter register a separate resource Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 3/9] ARM: orion: Assert watchdog RSTOUT enable bit Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 4/9] watchdog: orion: Remove RSTOUT bit enable/disable Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 5/9] watchdog: orion: Allow to build in any Orion platform Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 6/9] watchdog: orion: Rename device-tree binding documentation Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 7/9] watchdog: orion: Update " Ezequiel Garcia
2013-08-26 14:08   ` Jason Cooper
2013-08-26 14:08     ` Jason Cooper
2013-08-27  8:36     ` Ezequiel Garcia
2013-08-27  8:36       ` Ezequiel Garcia
2013-08-27  8:39       ` Thomas Petazzoni
2013-08-27  8:39         ` Thomas Petazzoni
2013-08-27 11:13         ` Jason Cooper
2013-08-27 11:13           ` Jason Cooper
2013-08-27 21:44       ` Stephen Warren [this message]
2013-08-27 21:44         ` Stephen Warren
2013-08-23 22:12 ` [PATCH v2 8/9] ARM: kirkwood: Update watchdog 'reg' property Ezequiel Garcia
2013-08-23 22:12 ` [PATCH v2 9/9] ARM: orion5x: Update orion-wdt DT node Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521D1DC9.5040409@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.