All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT
Date: Wed, 28 Aug 2013 12:14:24 +0200	[thread overview]
Message-ID: <521DCD80.9010105@gmail.com> (raw)
In-Reply-To: <20130828113521.35c53365@armhf>

On 08/28/2013 11:35 AM, Jean-Francois Moine wrote:
> This patch activates the audio device of the Cubox and sets the i2s
> and S/PDIF pins.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
>   arch/arm/boot/dts/dove-cubox.dts                  | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 4af59b6..003d95b 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -132,3 +132,16 @@
>   		reg = <0>;
>   	};
>   };
> +
> +&pinctrl {
> +	pmx_audio1_i2s1_spdifo: pmx-audio1-i2s1-spdifo {
> +		marvell,pins = "mpp_audio1";
> +		marvell,function = "i2s1/spdifo";
> +	};
> +};
> +
> +&i2s1 {
> +	status = "okay";
> +	pinctrl-0 = <&pmx_audio1_i2s1_spdifo>;
> +	pinctrl-names = "default";
> +};

Please also add the external clock connected from si5351.

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: linux-arm-kernel@lists.infradead.org,
	Jason Cooper <jason@lakedaemon.net>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT
Date: Wed, 28 Aug 2013 12:14:24 +0200	[thread overview]
Message-ID: <521DCD80.9010105@gmail.com> (raw)
In-Reply-To: <20130828113521.35c53365@armhf>

On 08/28/2013 11:35 AM, Jean-Francois Moine wrote:
> This patch activates the audio device of the Cubox and sets the i2s
> and S/PDIF pins.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
>   arch/arm/boot/dts/dove-cubox.dts                  | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 4af59b6..003d95b 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -132,3 +132,16 @@
>   		reg = <0>;
>   	};
>   };
> +
> +&pinctrl {
> +	pmx_audio1_i2s1_spdifo: pmx-audio1-i2s1-spdifo {
> +		marvell,pins = "mpp_audio1";
> +		marvell,function = "i2s1/spdifo";
> +	};
> +};
> +
> +&i2s1 {
> +	status = "okay";
> +	pinctrl-0 = <&pmx_audio1_i2s1_spdifo>;
> +	pinctrl-names = "default";
> +};

Please also add the external clock connected from si5351.

Sebastian

  reply	other threads:[~2013-08-28 10:14 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  9:35 [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT Jean-Francois Moine
2013-08-28  9:35 ` Jean-Francois Moine
2013-08-28 10:14 ` Sebastian Hesselbarth [this message]
2013-08-28 10:14   ` Sebastian Hesselbarth
2013-08-31 10:51   ` Jean-Francois Moine
2013-08-31 10:51     ` Jean-Francois Moine
2013-08-31 11:24     ` Russell King - ARM Linux
2013-08-31 11:24       ` Russell King - ARM Linux
2013-08-31 11:24       ` Russell King - ARM Linux
2013-08-31 11:55       ` Jean-Francois Moine
2013-08-31 11:55         ` Jean-Francois Moine
2013-08-31 12:17         ` Russell King - ARM Linux
2013-08-31 12:17           ` Russell King - ARM Linux
2013-08-31 12:17           ` Russell King - ARM Linux
2013-09-01  7:04       ` Jean-Francois Moine
2013-09-01  7:04         ` Jean-Francois Moine
2013-09-01  9:26     ` Sebastian Hesselbarth
2013-09-01  9:26       ` Sebastian Hesselbarth
2013-09-01  9:26       ` Sebastian Hesselbarth
2013-09-01 11:23       ` Jean-Francois Moine
2013-09-26  8:11       ` Jean-Francois Moine
2013-09-26  8:11         ` Jean-Francois Moine
2013-09-26  8:11         ` Jean-Francois Moine
2013-09-26  8:31         ` Sebastian Hesselbarth
2013-09-26  8:31           ` Sebastian Hesselbarth
2013-09-26 11:28           ` Jean-Francois Moine
2013-09-26 11:28             ` Jean-Francois Moine
2013-09-26 11:28             ` Jean-Francois Moine
2013-09-26 12:42             ` Sebastian Hesselbarth
2013-09-26 12:42               ` Sebastian Hesselbarth
2013-09-26 12:42               ` Sebastian Hesselbarth
2013-09-28 14:27             ` Sebastian Hesselbarth
2013-09-28 14:27               ` Sebastian Hesselbarth
2013-09-28 14:27               ` Sebastian Hesselbarth
2013-10-03 16:17               ` Jean-Francois Moine
2013-10-03 16:17                 ` Jean-Francois Moine
2013-10-03 16:17                 ` Jean-Francois Moine
2013-10-08 16:11                 ` Jason Cooper
2013-10-08 16:11                   ` Jason Cooper
2013-10-08 16:11                   ` Jason Cooper
2013-10-08 17:59                   ` Jean-Francois Moine
2013-10-08 17:59                     ` Jean-Francois Moine
2013-10-08 17:59                     ` Jean-Francois Moine
2013-10-08 18:00                     ` Jason Cooper
2013-10-08 18:00                       ` Jason Cooper
2013-10-08 18:00                       ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521DCD80.9010105@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.