All of lore.kernel.org
 help / color / mirror / Atom feed
* question about drivers/net/ethernet/mellanox/mlx4/en_tx.c
@ 2013-08-27 17:07 Julia Lawall
  2013-08-28 12:43 ` Amir Vadai
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2013-08-27 17:07 UTC (permalink / raw)
  To: amirv, netdev

Hello,

I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
are a number of uses of dma_sync_single_for_cpu without corresponding uses
of dma_sync_single_for_device (for example in mlx4_en_rx_skb)?  In most
drivers they come together.

thanks,
julia

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: question about drivers/net/ethernet/mellanox/mlx4/en_tx.c
  2013-08-27 17:07 question about drivers/net/ethernet/mellanox/mlx4/en_tx.c Julia Lawall
@ 2013-08-28 12:43 ` Amir Vadai
  2013-08-28 12:48   ` Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Amir Vadai @ 2013-08-28 12:43 UTC (permalink / raw)
  To: Julia Lawall; +Cc: netdev

On 27/08/2013 20:07, Julia Lawall wrote:
> Hello,
> 
> I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
> are a number of uses of dma_sync_single_for_cpu without corresponding uses
> of dma_sync_single_for_device (for example in mlx4_en_rx_skb)?  In most
> drivers they come together.
> 
> thanks,
> julia
> 

Hi Julia,

I guess you meant to en_rx.c and not en_tx.c

It looks like a bug.
The whole skb buffers allocation and mapping is expected to be
overhauled soon - and this will be fixed as part of it.

Thanks,
Amir

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: question about drivers/net/ethernet/mellanox/mlx4/en_tx.c
  2013-08-28 12:43 ` Amir Vadai
@ 2013-08-28 12:48   ` Julia Lawall
  0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2013-08-28 12:48 UTC (permalink / raw)
  To: Amir Vadai; +Cc: netdev

On Wed, 28 Aug 2013, Amir Vadai wrote:

> On 27/08/2013 20:07, Julia Lawall wrote:
> > Hello,
> >
> > I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
> > are a number of uses of dma_sync_single_for_cpu without corresponding uses
> > of dma_sync_single_for_device (for example in mlx4_en_rx_skb)?  In most
> > drivers they come together.
> >
> > thanks,
> > julia
> >
>
> Hi Julia,
>
> I guess you meant to en_rx.c and not en_tx.c

Oops, yes.

> It looks like a bug.
> The whole skb buffers allocation and mapping is expected to be
> overhauled soon - and this will be fixed as part of it.

OK, thanks for the explanation.

julia

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-28 12:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-27 17:07 question about drivers/net/ethernet/mellanox/mlx4/en_tx.c Julia Lawall
2013-08-28 12:43 ` Amir Vadai
2013-08-28 12:48   ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.