From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Kouei Abe <kouei.abe.cp@renesas.com>
Subject: Re: [PATCH net-next 2/2] sh_eth: Enable Rx descriptor word 0 shift for r8a7790
Date: Wed, 28 Aug 2013 15:05:46 +0000 [thread overview]
Message-ID: <521E11CA.1020503@cogentembedded.com> (raw)
In-Reply-To: <1377650589-20960-3-git-send-email-horms+renesas@verge.net.au>
Hello.
On 08/28/2013 04:43 AM, Simon Horman wrote:
> From: Kouei Abe <kouei.abe.cp@renesas.com>
> This corrects an oversight when r8a7790 support was added to sh_eth.
No wonder it was overseen -- it's undocumented as of version 0.60 of the
manual.
> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index f386a8f..095ca8e 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -416,6 +416,7 @@ static struct sh_eth_cpu_data r8a7790_data = {
> .tpauser = 1,
> .hw_swap = 1,
> .rmiimode = 1,
> + .shift_rd0 = 1,
I've seen the corresponding code in a Renesas BSP but wanted to double
check before sending...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Kouei Abe <kouei.abe.cp@renesas.com>
Subject: Re: [PATCH net-next 2/2] sh_eth: Enable Rx descriptor word 0 shift for r8a7790
Date: Wed, 28 Aug 2013 19:05:46 +0400 [thread overview]
Message-ID: <521E11CA.1020503@cogentembedded.com> (raw)
In-Reply-To: <1377650589-20960-3-git-send-email-horms+renesas@verge.net.au>
Hello.
On 08/28/2013 04:43 AM, Simon Horman wrote:
> From: Kouei Abe <kouei.abe.cp@renesas.com>
> This corrects an oversight when r8a7790 support was added to sh_eth.
No wonder it was overseen -- it's undocumented as of version 0.60 of the
manual.
> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index f386a8f..095ca8e 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -416,6 +416,7 @@ static struct sh_eth_cpu_data r8a7790_data = {
> .tpauser = 1,
> .hw_swap = 1,
> .rmiimode = 1,
> + .shift_rd0 = 1,
I've seen the corresponding code in a Renesas BSP but wanted to double
check before sending...
WBR, Sergei
next prev parent reply other threads:[~2013-08-28 15:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 0:43 [PATCH net-next 0/2] sh_eth Updates Simon Horman
2013-08-28 0:43 ` Simon Horman
2013-08-28 0:43 ` [PATCH net-next 1/2] sh_eth: Fix cache invalidation omission of receive buffer Simon Horman
2013-08-28 0:43 ` Simon Horman
2013-08-29 20:15 ` David Miller
2013-08-29 20:15 ` David Miller
2013-08-30 0:16 ` Simon Horman
2013-08-30 0:16 ` Simon Horman
2013-08-28 0:43 ` [PATCH net-next 2/2] sh_eth: Enable Rx descriptor word 0 shift for r8a7790 Simon Horman
2013-08-28 0:43 ` Simon Horman
2013-08-28 15:05 ` Sergei Shtylyov [this message]
2013-08-28 15:05 ` Sergei Shtylyov
2013-08-29 0:06 ` Simon Horman
2013-08-29 0:06 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521E11CA.1020503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=kouei.abe.cp@renesas.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.