* [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build)
@ 2013-08-28 17:28 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-08-28 17:28 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Stefan Weil, Richard Henderson
Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
tcg/tci/tcg-target.c already had a nearly identical implementation which is
now removed to fix a compiler error.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tcg/tci/tcg-target.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index e118bc7..eb23832 100644
--- a/tcg/tci/tcg-target.c
+++ b/tcg/tci/tcg-target.c
@@ -415,13 +415,6 @@ static void tcg_out_i(TCGContext *s, tcg_target_ulong v)
s->code_ptr += sizeof(tcg_target_ulong);
}
-/* Write 64 bit value. */
-static void tcg_out64(TCGContext *s, uint64_t v)
-{
- *(uint64_t *)s->code_ptr = v;
- s->code_ptr += sizeof(v);
-}
-
/* Write opcode. */
static void tcg_out_op_t(TCGContext *s, TCGOpcode op)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] tci: Remove function tcg_out64 (fix broken build)
@ 2013-08-28 17:28 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-08-28 17:28 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Stefan Weil, Richard Henderson
Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
tcg/tci/tcg-target.c already had a nearly identical implementation which is
now removed to fix a compiler error.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tcg/tci/tcg-target.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index e118bc7..eb23832 100644
--- a/tcg/tci/tcg-target.c
+++ b/tcg/tci/tcg-target.c
@@ -415,13 +415,6 @@ static void tcg_out_i(TCGContext *s, tcg_target_ulong v)
s->code_ptr += sizeof(tcg_target_ulong);
}
-/* Write 64 bit value. */
-static void tcg_out64(TCGContext *s, uint64_t v)
-{
- *(uint64_t *)s->code_ptr = v;
- s->code_ptr += sizeof(v);
-}
-
/* Write opcode. */
static void tcg_out_op_t(TCGContext *s, TCGOpcode op)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build)
2013-08-28 17:28 ` [Qemu-devel] " Stefan Weil
@ 2013-08-28 18:06 ` Richard Henderson
-1 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2013-08-28 18:06 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On 08/28/2013 10:28 AM, Stefan Weil wrote:
> Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
> tcg/tci/tcg-target.c already had a nearly identical implementation which is
> now removed to fix a compiler error.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Oops, yes.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] tci: Remove function tcg_out64 (fix broken build)
@ 2013-08-28 18:06 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2013-08-28 18:06 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On 08/28/2013 10:28 AM, Stefan Weil wrote:
> Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
> tcg/tci/tcg-target.c already had a nearly identical implementation which is
> now removed to fix a compiler error.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Oops, yes.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build)
2013-08-28 17:28 ` [Qemu-devel] " Stefan Weil
@ 2013-09-01 15:37 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-09-01 15:37 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Richard Henderson
28.08.2013 21:28, Stefan Weil wrote:
> Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
> tcg/tci/tcg-target.c already had a nearly identical implementation which is
> now removed to fix a compiler error.
Thanks, applied to the trivial-patches queue.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build)
@ 2013-09-01 15:37 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-09-01 15:37 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Richard Henderson
28.08.2013 21:28, Stefan Weil wrote:
> Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
> tcg/tci/tcg-target.c already had a nearly identical implementation which is
> now removed to fix a compiler error.
Thanks, applied to the trivial-patches queue.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-01 15:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-28 17:28 [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build) Stefan Weil
2013-08-28 17:28 ` [Qemu-devel] " Stefan Weil
2013-08-28 18:06 ` [Qemu-trivial] " Richard Henderson
2013-08-28 18:06 ` [Qemu-devel] " Richard Henderson
2013-09-01 15:37 ` [Qemu-trivial] " Michael Tokarev
2013-09-01 15:37 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.