From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling
Date: Thu, 29 Aug 2013 08:29:56 +0200 [thread overview]
Message-ID: <521EEA64.7000708@redhat.com> (raw)
In-Reply-To: <521EB16F.9010303@ozlabs.ru>
Il 29/08/2013 04:26, Alexey Kardashevskiy ha scritto:
>
> Right. I was planning to add my IOMMU stuff right before calculating @end.
But then the non-IOMMU stuff can just use int128_get64, no? So even if
this patch simply uses int128_get64, it is still a suitable basis for
adding IOMMU stuff.
Paolo
>
>> > This patch is not maintainable. We're seemingly
>> > calculating the same value twice with no comment as to why. A hwaddr
>> > type end should be calculated from the Int128 rather than paying
>> > attention to rollover in one place but not another. Thanks,
> Yes, not maintainable... I guess I just have to convert @end to 128 bit as
> well to have things consistent.
next prev parent reply other threads:[~2013-08-29 6:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 11:29 [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 1/3] int128: add int128_exts64() Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 2/3] vfio: Fix debug output for int128 values Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling Alexey Kardashevskiy
2013-08-28 15:18 ` Alex Williamson
2013-08-29 1:03 ` Alexey Kardashevskiy
2013-08-29 1:42 ` Alex Williamson
2013-08-29 2:26 ` Alexey Kardashevskiy
2013-08-29 6:29 ` Paolo Bonzini [this message]
2013-08-29 6:58 ` Alexey Kardashevskiy
2013-08-29 8:50 ` Paolo Bonzini
2013-08-30 6:15 ` Alexey Kardashevskiy
2013-08-30 6:39 ` Paolo Bonzini
2013-08-30 6:42 ` Alexey Kardashevskiy
2013-08-28 9:46 ` [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-28 11:09 ` Paolo Bonzini
2013-08-28 14:10 ` Alex Williamson
2013-08-28 14:29 ` Paolo Bonzini
2013-09-10 4:23 ` Alexey Kardashevskiy
2013-09-10 6:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521EEA64.7000708@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.