From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling
Date: Fri, 30 Aug 2013 16:42:10 +1000 [thread overview]
Message-ID: <52203EC2.7030801@ozlabs.ru> (raw)
In-Reply-To: <52203E1C.4060208@redhat.com>
On 08/30/2013 04:39 PM, Paolo Bonzini wrote:
> Il 30/08/2013 08:15, Alexey Kardashevskiy ha scritto:
>>>> What if you just merge the two series together?
>> It will still be a function which can accept sections bigger than 2^64 and
>> theoretically call int128_get64() and assert. I would think that every time
>> when anyone calls int128_get64(), the value should be checked for <2^64. It
>> is like division by zero :)
>
> I understood that int128_get64() would be called only for RAM sections,
> not for IOMMUs (and RAM sections cannot be 2^64-bytes large). Is this
> wrong?
This is correct but for people who do not know when and in what state it is
called, it can be confusing. Ok, I'll merge this with my vfio patches.
--
Alexey
next prev parent reply other threads:[~2013-08-30 6:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 11:29 [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 1/3] int128: add int128_exts64() Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 2/3] vfio: Fix debug output for int128 values Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling Alexey Kardashevskiy
2013-08-28 15:18 ` Alex Williamson
2013-08-29 1:03 ` Alexey Kardashevskiy
2013-08-29 1:42 ` Alex Williamson
2013-08-29 2:26 ` Alexey Kardashevskiy
2013-08-29 6:29 ` Paolo Bonzini
2013-08-29 6:58 ` Alexey Kardashevskiy
2013-08-29 8:50 ` Paolo Bonzini
2013-08-30 6:15 ` Alexey Kardashevskiy
2013-08-30 6:39 ` Paolo Bonzini
2013-08-30 6:42 ` Alexey Kardashevskiy [this message]
2013-08-28 9:46 ` [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-28 11:09 ` Paolo Bonzini
2013-08-28 14:10 ` Alex Williamson
2013-08-28 14:29 ` Paolo Bonzini
2013-09-10 4:23 ` Alexey Kardashevskiy
2013-09-10 6:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52203EC2.7030801@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.