All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode()
@ 2013-08-27 21:05 akpm at linux-foundation.org
  2013-08-29  9:54 ` Jeff Liu
  0 siblings, 1 reply; 2+ messages in thread
From: akpm at linux-foundation.org @ 2013-08-27 21:05 UTC (permalink / raw)
  To: ocfs2-devel

From: Joseph Qi <joseph.qi@huawei.com>
Subject: ocfs2: remove unused variable ip in dlmfs_get_root_inode()

Variable ip in dlmfs_get_root_inode() is defined but not used.  So clean
it up.

Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/ocfs2/dlmfs/dlmfs.c |    3 ---
 1 file changed, 3 deletions(-)

diff -puN fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode fs/ocfs2/dlmfs/dlmfs.c
--- a/fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode
+++ a/fs/ocfs2/dlmfs/dlmfs.c
@@ -401,11 +401,8 @@ static struct inode *dlmfs_get_root_inod
 {
 	struct inode *inode = new_inode(sb);
 	umode_t mode = S_IFDIR | 0755;
-	struct dlmfs_inode_private *ip;
 
 	if (inode) {
-		ip = DLMFS_I(inode);
-
 		inode->i_ino = get_next_ino();
 		inode_init_owner(inode, NULL, mode);
 		inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode()
  2013-08-27 21:05 [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode() akpm at linux-foundation.org
@ 2013-08-29  9:54 ` Jeff Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2013-08-29  9:54 UTC (permalink / raw)
  To: ocfs2-devel

On 08/28/2013 05:05 AM, akpm at linux-foundation.org wrote:

> From: Joseph Qi <joseph.qi@huawei.com>
> Subject: ocfs2: remove unused variable ip in dlmfs_get_root_inode()
> 
> Variable ip in dlmfs_get_root_inode() is defined but not used.  So clean
> it up.
> 
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Looks good.  Reviewed-by: Jie Liu <jeff.liu@oracle.com>

> ---
> 
>  fs/ocfs2/dlmfs/dlmfs.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff -puN fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode fs/ocfs2/dlmfs/dlmfs.c
> --- a/fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode
> +++ a/fs/ocfs2/dlmfs/dlmfs.c
> @@ -401,11 +401,8 @@ static struct inode *dlmfs_get_root_inod
>  {
>  	struct inode *inode = new_inode(sb);
>  	umode_t mode = S_IFDIR | 0755;
> -	struct dlmfs_inode_private *ip;
>  
>  	if (inode) {
> -		ip = DLMFS_I(inode);
> -
>  		inode->i_ino = get_next_ino();
>  		inode_init_owner(inode, NULL, mode);
>  		inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
> _
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-29  9:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-27 21:05 [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode() akpm at linux-foundation.org
2013-08-29  9:54 ` Jeff Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.