From: Ian Molton <ian.molton@codethink.co.uk>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-i2c@vger.kernel.org, Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] EMMA: Add em i2c driver
Date: Thu, 29 Aug 2013 14:35:35 +0100 [thread overview]
Message-ID: <521F4E27.1070800@codethink.co.uk> (raw)
In-Reply-To: <521F2156.6040506@codethink.co.uk>
On 29/08/13 11:24, Ben Dooks wrote:
> On 29/08/13 06:33, Magnus Damm wrote:
>> Hi Ian,
>>
>> Thanks for submitting this patch. I have one comment only, please see
>> below.
>>> +#ifdef CONFIG_I2C_EMXX_SMC
>>> + i2c_dev->flags |= I2C_BIT_SMC0;
>>> +#endif
>>
>> I think CONFIG_I2C_EMXX_SMC probably want to be reworked somehow. I
>> assume it's an old left over in this particular case. But if you need
>> to have some special configuration method then please consider some
>> other way than CONFIG_ variables that are not very compatible with
>> future multi-platform kernel images.
>
> Is it something that needs to be passed through the device tree binding
> or something we can detect from the SoC itself?
>
Probably. Its the switch to select between 100 and 400kHz modes.
I wonder if theres a standard binding for it?
-Ian
WARNING: multiple messages have this Message-ID (diff)
From: Ian Molton <ian.molton@codethink.co.uk>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-i2c@vger.kernel.org, Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] EMMA: Add em i2c driver
Date: Thu, 29 Aug 2013 13:35:35 +0000 [thread overview]
Message-ID: <521F4E27.1070800@codethink.co.uk> (raw)
In-Reply-To: <521F2156.6040506@codethink.co.uk>
On 29/08/13 11:24, Ben Dooks wrote:
> On 29/08/13 06:33, Magnus Damm wrote:
>> Hi Ian,
>>
>> Thanks for submitting this patch. I have one comment only, please see
>> below.
>>> +#ifdef CONFIG_I2C_EMXX_SMC
>>> + i2c_dev->flags |= I2C_BIT_SMC0;
>>> +#endif
>>
>> I think CONFIG_I2C_EMXX_SMC probably want to be reworked somehow. I
>> assume it's an old left over in this particular case. But if you need
>> to have some special configuration method then please consider some
>> other way than CONFIG_ variables that are not very compatible with
>> future multi-platform kernel images.
>
> Is it something that needs to be passed through the device tree binding
> or something we can detect from the SoC itself?
>
Probably. Its the switch to select between 100 and 400kHz modes.
I wonder if theres a standard binding for it?
-Ian
next prev parent reply other threads:[~2013-08-29 13:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1377688911-10911-1-git-send-email-ian.molton@codethink.co.uk>
2013-08-29 5:33 ` [PATCH] EMMA: Add em i2c driver Magnus Damm
2013-08-29 5:33 ` Magnus Damm
[not found] ` <CANqRtoRK+Ur=87-me7CpP+s9SO5g0ZVZSEOrqwDf4HFfjZZmZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-29 10:24 ` Ben Dooks
2013-08-29 10:24 ` Ben Dooks
2013-08-29 13:35 ` Ian Molton [this message]
2013-08-29 13:35 ` Ian Molton
2013-09-03 11:30 ` EMMA I2C driver Ian Molton
2013-09-03 11:30 ` Ian Molton
2013-09-03 11:30 ` [PATCH] EMMA: Add em i2c driver Ian Molton
2013-09-03 11:30 ` Ian Molton
2013-09-03 12:56 ` Ben Dooks
2013-09-03 12:56 ` Ben Dooks
[not found] ` <5225DC8E.7070001-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2013-09-04 12:06 ` Thomas Petazzoni
2013-09-04 12:06 ` Thomas Petazzoni
[not found] ` <1377688911-10911-1-git-send-email-ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2013-09-03 16:49 ` [Patch v3]EMMA I2C driver Ian Molton
2013-09-03 16:49 ` Ian Molton
2013-09-03 16:49 ` [PATCH 1/2] I2C: EMMA Mobile I2C master driver Ian Molton
2013-09-03 16:49 ` Ian Molton
2013-09-05 6:04 ` Simon Horman
2013-09-05 6:04 ` Simon Horman
2013-09-25 4:45 ` Simon Horman
2013-09-25 4:45 ` Simon Horman
2013-12-06 20:52 ` Ian Molton
2013-12-11 2:09 ` Simon Horman
2013-12-11 2:09 ` Simon Horman
2013-12-11 11:59 ` Wolfram Sang
2013-12-11 11:59 ` Wolfram Sang
2014-01-08 10:33 ` Ian Molton
[not found] ` <1378226969-18722-2-git-send-email-ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-02-18 17:38 ` Wolfram Sang
2014-02-18 17:38 ` Wolfram Sang
2014-06-17 9:57 ` Wolfram Sang
2014-06-17 9:57 ` Wolfram Sang
2014-07-18 15:45 ` Wolfram Sang
2014-07-18 15:45 ` Wolfram Sang
2014-08-22 2:57 ` Wolfram Sang
2014-08-22 2:57 ` Wolfram Sang
2013-08-28 14:04 [PATCH] EMMA: Add em i2c driver y
2013-08-28 14:10 ` Ben Dooks
2013-08-28 14:10 ` Ben Dooks
2013-08-28 15:08 ` Ian Molton
-- strict thread matches above, loose matches on Subject: below --
2013-08-28 14:04 y
2013-08-28 14:04 y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F4E27.1070800@codethink.co.uk \
--to=ian.molton@codethink.co.uk \
--cc=ben.dooks@codethink.co.uk \
--cc=grant.likely@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.