All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 00/03] ARM: shmobile: r8a7790 APMU SMP support
Date: Thu, 29 Aug 2013 17:20:45 +0000	[thread overview]
Message-ID: <521F82ED.7020901@arm.com> (raw)
In-Reply-To: <20130828232148.7321.45739.sendpatchset@w520>

On 29/08/13 00:21, Magnus Damm wrote:
> ARM: shmobile: r8a7790 APMU SMP support
> 
> [PATCH v2 01/03] ARM: shmobile: Shared APMU SMP support code without DT
> [PATCH v2 02/03] ARM: shmobile: Add r8a7790 SMP support using APMU code
> [PATCH v2 03/03] ARM: shmobile: Add r8a7790 CA15 CPU cores
> 
> This series adds SMP support to r8a7790 using the included APMU code.
> The previous version of r8a7790 support depended on the APMU code in 
> "[PATCH] ARM: shmobile: Shared APMU SMP support code", but in this
> version the APMU code has been reworked to not use DT.
You have misunderstood my comments. I clearly said I am not against
using DT for APMU. I objected only the new property 'cpus' added to the
APMU node(mainly because it's not needed IMO or it was not documented
well to explain the need for it)

> In the future
> r8a73a4 and other SoCs may make use of the APMU as well, but the 
> r8a73a4 code first needs to be adjusted to work with the CCI driver.
> 
> With these patches applied r8a7790 CA15 support for SMP boot
> and CPU Hotplug is known to be working.
> 
> Thanks to Sudeep for his feedback.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Written against renesas.git renesas-devel-20130829
> 
>  arch/arm/boot/dts/r8a7790.dtsi                 |   21 ++
>  arch/arm/mach-shmobile/Makefile                |    1 
>  arch/arm/mach-shmobile/board-lager-reference.c |    1 
>  arch/arm/mach-shmobile/board-lager.c           |    1 
>  arch/arm/mach-shmobile/include/mach/common.h   |    6 
>  arch/arm/mach-shmobile/include/mach/r8a7790.h  |    1 
>  arch/arm/mach-shmobile/platsmp-apmu.c          |  178 ++++++++++++++++++++++++
>  arch/arm/mach-shmobile/setup-r8a7790.c         |    1 
>  arch/arm/mach-shmobile/smp-r8a7790.c           |   67 +++++++++
>  9 files changed, 277 insertions(+)
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: Sudeep.KarkadaNagesha@arm.com (Sudeep KarkadaNagesha)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/03] ARM: shmobile: r8a7790 APMU SMP support
Date: Thu, 29 Aug 2013 18:20:45 +0100	[thread overview]
Message-ID: <521F82ED.7020901@arm.com> (raw)
In-Reply-To: <20130828232148.7321.45739.sendpatchset@w520>

On 29/08/13 00:21, Magnus Damm wrote:
> ARM: shmobile: r8a7790 APMU SMP support
> 
> [PATCH v2 01/03] ARM: shmobile: Shared APMU SMP support code without DT
> [PATCH v2 02/03] ARM: shmobile: Add r8a7790 SMP support using APMU code
> [PATCH v2 03/03] ARM: shmobile: Add r8a7790 CA15 CPU cores
> 
> This series adds SMP support to r8a7790 using the included APMU code.
> The previous version of r8a7790 support depended on the APMU code in 
> "[PATCH] ARM: shmobile: Shared APMU SMP support code", but in this
> version the APMU code has been reworked to not use DT.
You have misunderstood my comments. I clearly said I am not against
using DT for APMU. I objected only the new property 'cpus' added to the
APMU node(mainly because it's not needed IMO or it was not documented
well to explain the need for it)

> In the future
> r8a73a4 and other SoCs may make use of the APMU as well, but the 
> r8a73a4 code first needs to be adjusted to work with the CCI driver.
> 
> With these patches applied r8a7790 CA15 support for SMP boot
> and CPU Hotplug is known to be working.
> 
> Thanks to Sudeep for his feedback.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Written against renesas.git renesas-devel-20130829
> 
>  arch/arm/boot/dts/r8a7790.dtsi                 |   21 ++
>  arch/arm/mach-shmobile/Makefile                |    1 
>  arch/arm/mach-shmobile/board-lager-reference.c |    1 
>  arch/arm/mach-shmobile/board-lager.c           |    1 
>  arch/arm/mach-shmobile/include/mach/common.h   |    6 
>  arch/arm/mach-shmobile/include/mach/r8a7790.h  |    1 
>  arch/arm/mach-shmobile/platsmp-apmu.c          |  178 ++++++++++++++++++++++++
>  arch/arm/mach-shmobile/setup-r8a7790.c         |    1 
>  arch/arm/mach-shmobile/smp-r8a7790.c           |   67 +++++++++
>  9 files changed, 277 insertions(+)
> 
> 

  parent reply	other threads:[~2013-08-29 17:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 23:21 [PATCH v2 00/03] ARM: shmobile: r8a7790 APMU SMP support Magnus Damm
2013-08-28 23:21 ` Magnus Damm
2013-08-28 23:21 ` [PATCH v2 01/03] ARM: shmobile: Shared APMU SMP support code without DT Magnus Damm
2013-08-28 23:21   ` Magnus Damm
2013-08-28 23:22 ` [PATCH v2 02/03] ARM: shmobile: Add r8a7790 SMP support using APMU code Magnus Damm
2013-08-28 23:22   ` Magnus Damm
2013-08-28 23:22 ` [PATCH v2 03/03] ARM: shmobile: Add r8a7790 CA15 CPU cores Magnus Damm
2013-08-28 23:22   ` Magnus Damm
2013-08-29  0:18 ` [PATCH v2 00/03] ARM: shmobile: r8a7790 APMU SMP support Simon Horman
2013-08-29  0:18   ` Simon Horman
2013-08-29  4:11   ` Magnus Damm
2013-08-29  4:11     ` Magnus Damm
2013-08-29  4:34     ` Simon Horman
2013-08-29  4:34       ` Simon Horman
2013-09-04  8:39       ` Simon Horman
2013-09-04  8:39         ` Simon Horman
2013-09-10 12:19         ` Sudeep KarkadaNagesha
2013-09-10 12:19           ` Sudeep KarkadaNagesha
2013-09-11  3:48           ` Simon Horman
2013-09-11  3:48             ` Simon Horman
2013-08-29 17:20 ` Sudeep KarkadaNagesha [this message]
2013-08-29 17:20   ` Sudeep KarkadaNagesha
2013-09-10 12:12 ` Guennadi Liakhovetski
2013-09-10 12:12   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521F82ED.7020901@arm.com \
    --to=sudeep.karkadanagesha@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.