All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 13/15] OMAPDSS: DSS: remove legacy dss bus support
Date: Fri, 30 Aug 2013 05:52:12 +0000	[thread overview]
Message-ID: <5220330C.9010704@ti.com> (raw)
In-Reply-To: <521F5B80.6080802@ti.com>

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

On 29/08/13 17:32, Archit Taneja wrote:
> On Thursday 29 August 2013 07:01 PM, Tomi Valkeinen wrote:
>> With all the old panels removed and all the old panel model APIs removed
>> from the DSS encoders, we can now remove the custom omapdss-bus which
>> was used in the old panel model.
>>

>>   static void __exit omap_dss_exit(void)
>>   {
>>       omap_dss_unregister_drivers();
>> -
>> -    omap_dss_bus_unregister();
>>   }
>>
>>   module_init(omap_dss_init);
>>   module_exit(omap_dss_exit);
> 
> minor comment here, we could use
> omap_dss_register_driver/unregister_driver for the module_init/exit
> directly, the funcs omap_dss_init/ext don't seem to be doing much here.

Yes, that's true. I'll clean it up.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 13/15] OMAPDSS: DSS: remove legacy dss bus support
Date: Fri, 30 Aug 2013 08:52:12 +0300	[thread overview]
Message-ID: <5220330C.9010704@ti.com> (raw)
In-Reply-To: <521F5B80.6080802@ti.com>

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

On 29/08/13 17:32, Archit Taneja wrote:
> On Thursday 29 August 2013 07:01 PM, Tomi Valkeinen wrote:
>> With all the old panels removed and all the old panel model APIs removed
>> from the DSS encoders, we can now remove the custom omapdss-bus which
>> was used in the old panel model.
>>

>>   static void __exit omap_dss_exit(void)
>>   {
>>       omap_dss_unregister_drivers();
>> -
>> -    omap_dss_bus_unregister();
>>   }
>>
>>   module_init(omap_dss_init);
>>   module_exit(omap_dss_exit);
> 
> minor comment here, we could use
> omap_dss_register_driver/unregister_driver for the module_init/exit
> directly, the funcs omap_dss_init/ext don't seem to be doing much here.

Yes, that's true. I'll clean it up.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2013-08-30  5:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 13:31 [PATCH 00/15] OMAPDSS: remove old panel model code Tomi Valkeinen
2013-08-29 13:31 ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 01/15] OMAPDSS: RFBI: Mark RFBI as broken Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 02/15] OMAPDSS: remove omap_dss_device->channel field Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 03/15] OMAPDSS: fix DPI and SDI device ids Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-09-17 16:20   ` Tony Lindgren
2013-09-17 16:20     ` Tony Lindgren
2013-08-29 13:31 ` [PATCH 04/15] OMAPDSS: SDI: change regulator handling Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 05/15] OMAPDSS: DPI: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 07/15] OMAPDSS: DPI: remove code related to old panel model Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 08/15] OMAPDSS: HDMI: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 09/15] OMAPDSS: DSI: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 10/15] OMAPDSS: SDI: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 11/15] OMAPDSS: VENC: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 12/15] OMAPDSS: RFBI: " Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 13/15] OMAPDSS: DSS: remove legacy dss bus support Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 14:32   ` Archit Taneja
2013-08-29 14:44     ` Archit Taneja
2013-08-30  5:52     ` Tomi Valkeinen [this message]
2013-08-30  5:52       ` Tomi Valkeinen
2013-08-29 13:31 ` [PATCH 14/15] OMAPDSS: rename omap_dss_device's 'output' to 'src' Tomi Valkeinen
2013-08-29 13:31   ` Tomi Valkeinen
2013-08-29 13:32 ` [PATCH 15/15] OMAPDSS: rename omap_dss_device's 'device' field to 'dst' Tomi Valkeinen
2013-08-29 13:32   ` Tomi Valkeinen
     [not found] ` <1377783120-14001-7-git-send-email-tomi.valkeinen@ti.com>
     [not found]   ` <521F53F0.4030203@ti.com>
2013-08-29 14:06     ` [PATCH 06/15] OMAPDSS: remove all old panel drivers Tomi Valkeinen
2013-08-29 14:06       ` Tomi Valkeinen
2013-08-29 14:08       ` Archit Taneja
2013-08-29 14:20         ` Archit Taneja
2013-08-29 14:35 ` [PATCH 00/15] OMAPDSS: remove old panel model code Archit Taneja
2013-08-29 14:47   ` Archit Taneja
2013-08-30  6:00   ` Tomi Valkeinen
2013-08-30  6:00     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220330C.9010704@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=archit@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.