From: Jianguo Wu <wujianguo@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>, laijs@cn.fujitsu.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
zhangyanfei@cn.fujitsu.com, David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/5] mm/vmalloc: use N_MEMORY instead of N_HIGH_MEMORY
Date: Fri, 30 Aug 2013 17:10:05 +0800 [thread overview]
Message-ID: <5220616D.6030403@huawei.com> (raw)
In-Reply-To: <5220133E.4030204@huawei.com>
On 2013/8/30 11:36, Jianguo Wu wrote:
> Since commit 8219fc48a(mm: node_states: introduce N_MEMORY),
> we introduced N_MEMORY, now N_MEMORY stands for the nodes that has any memory,
> and N_HIGH_MEMORY stands for the nodes that has normal or high memory.
>
> The code here need to handle with the nodes which have memory,
> we should use N_MEMORY instead.
>
As Michal pointed out in http://marc.info/?l=linux-kernel&m=137784852720861&w=2,
N_HIGH_MEMORY should be kept in these places, please ignore this series.
Sorry for the noise.
Thanks.
> Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 13a5495..1152947 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2573,7 +2573,7 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
> for (nr = 0; nr < v->nr_pages; nr++)
> counters[page_to_nid(v->pages[nr])]++;
>
> - for_each_node_state(nr, N_HIGH_MEMORY)
> + for_each_node_state(nr, N_MEMORY)
> if (counters[nr])
> seq_printf(m, " N%u=%u", nr, counters[nr]);
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jianguo Wu <wujianguo@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>, <laijs@cn.fujitsu.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
<zhangyanfei@cn.fujitsu.com>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 1/5] mm/vmalloc: use N_MEMORY instead of N_HIGH_MEMORY
Date: Fri, 30 Aug 2013 17:10:05 +0800 [thread overview]
Message-ID: <5220616D.6030403@huawei.com> (raw)
In-Reply-To: <5220133E.4030204@huawei.com>
On 2013/8/30 11:36, Jianguo Wu wrote:
> Since commit 8219fc48a(mm: node_states: introduce N_MEMORY),
> we introduced N_MEMORY, now N_MEMORY stands for the nodes that has any memory,
> and N_HIGH_MEMORY stands for the nodes that has normal or high memory.
>
> The code here need to handle with the nodes which have memory,
> we should use N_MEMORY instead.
>
As Michal pointed out in http://marc.info/?l=linux-kernel&m=137784852720861&w=2,
N_HIGH_MEMORY should be kept in these places, please ignore this series.
Sorry for the noise.
Thanks.
> Signed-off-by: Jianguo Wu <wujianguo@huawei.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 13a5495..1152947 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2573,7 +2573,7 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
> for (nr = 0; nr < v->nr_pages; nr++)
> counters[page_to_nid(v->pages[nr])]++;
>
> - for_each_node_state(nr, N_HIGH_MEMORY)
> + for_each_node_state(nr, N_MEMORY)
> if (counters[nr])
> seq_printf(m, " N%u=%u", nr, counters[nr]);
> }
next prev parent reply other threads:[~2013-08-30 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 3:36 [PATCH 1/5] mm/vmalloc: use N_MEMORY instead of N_HIGH_MEMORY Jianguo Wu
2013-08-30 3:36 ` Jianguo Wu
2013-08-30 9:10 ` Jianguo Wu [this message]
2013-08-30 9:10 ` Jianguo Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220616D.6030403@huawei.com \
--to=wujianguo@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.