* [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu_recv()
@ 2013-08-30 10:04 Ding Tianhong
2013-08-30 17:07 ` Rick Jones
0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2013-08-30 10:04 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, David S. Miller,
Nikolay Aleksandrov, Veaceslav Falico, Netdev
There is no pointer needed read lock protection, remove the unnecessary lock
and improve performance for the 3ad recv path.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Cc: Nikolay Aleksandrov <nikolay@redhat.com>
---
drivers/net/bonding/bond_3ad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 7a3860f..c134f43 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -2494,9 +2494,7 @@ int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
if (!lacpdu)
return ret;
- read_lock(&bond->lock);
ret = bond_3ad_rx_indication(lacpdu, slave, skb->len);
- read_unlock(&bond->lock);
return ret;
}
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu_recv()
2013-08-30 10:04 [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu_recv() Ding Tianhong
@ 2013-08-30 17:07 ` Rick Jones
0 siblings, 0 replies; 2+ messages in thread
From: Rick Jones @ 2013-08-30 17:07 UTC (permalink / raw)
To: Ding Tianhong
Cc: Jay Vosburgh, Andy Gospodarek, David S. Miller,
Nikolay Aleksandrov, Veaceslav Falico, Netdev
On 08/30/2013 03:04 AM, Ding Tianhong wrote:
> There is no pointer needed read lock protection, remove the unnecessary lock
> and improve performance for the 3ad recv path.
Improve performance by how much? For example, by how much is service
demand lower on a netperf TCP_STREAM or TCP_RR test through a bond. I
suppose that applies not only to this specific patch to to the set as a
whole.
rick jones
>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> Cc: Nikolay Aleksandrov <nikolay@redhat.com>
> ---
> drivers/net/bonding/bond_3ad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 7a3860f..c134f43 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -2494,9 +2494,7 @@ int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
> if (!lacpdu)
> return ret;
>
> - read_lock(&bond->lock);
> ret = bond_3ad_rx_indication(lacpdu, slave, skb->len);
> - read_unlock(&bond->lock);
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-30 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 10:04 [PATCH net-next 2/6] bonding: remove the no effect lock for bond_3ad_lacpdu_recv() Ding Tianhong
2013-08-30 17:07 ` Rick Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.