Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

On 08/30/2013 12:13 PM, Alex Bligh wrote:

>>> +# test of qemu-img convert -n - convert without creation
>>> +#
>>> +# Copyright (C) 2009 Red Hat, Inc.
> 
>> Where have you been the last 4 years?  I could understand a range of
>> years, if this test borrows significantly from another file that old,
>> but I suspect that just 2013 is probably more accurate.
> 
> I've been not at Redhat for any of it!
> 
> I wasn't too sure what to do with the copyright string. The body of
> the code was copied from another test (058 if I remember rightly)
> which had the above copyright string which is presumably that old.

If so, and if I reviewed that patch, shame on me for not noticing the
stale year on that test :)

> Redhat don't have any copyright in the stuff I added so there is
> no (c) Redhat newer than (presumably) 2009 (I'm presuming qemu
> doesn't require contributor assignment). My copyright would be 2013.

Your own work is non-trivial - by virtue of the fact that you list:

+owner=alex@alex.org.uk

you are stating that there is enough new content comprising this test
that you feel comfortable being listed as the point of contact for the file.

> But removing Redhat's (c) or altering it did not seem right.

Indeed, since you are copying a substantial amount of template from Red
Hat's copyright.

> 
> I'm really not bothered about having my own string in there
> particularly for such a meagre bit of code, but I suppose most
> accurate would be:
> 
>   (c) 2009 Red Hat, Inc.
>   (c) 2013 Alex Bligh

Yes, that looks like the best approach.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]