All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	hpa@linux.intel.com, yinghai@kernel.org, jacob.shin@amd.com,
	konrad.wilk@oracle.com, linux-mm@kvack.org,
	Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH] x86: e820: fix memmap kernel boot parameter
Date: Fri, 30 Aug 2013 13:39:48 -0700	[thread overview]
Message-ID: <52210314.4080408@zytor.com> (raw)
In-Reply-To: <1377841673-17361-1-git-send-email-bob.liu@oracle.com>

On 08/29/2013 10:47 PM, Bob Liu wrote:
> Kernel boot parameter memmap=nn[KMG]$ss[KMG] is used to mark specific memory as
> reserved. Region of memory to be used is from ss to ss+nn.
> 
> But I found the action of this parameter is not as expected.
> I tried on two machines.
> Machine1: bootcmdline in grub.cfg "memmap=800M$0x60bfdfff", but the result of
> "cat /proc/cmdline" changed to "memmap=800M/bin/bashx60bfdfff" after system
> booted.
> 
> Machine2: bootcmdline in grub.cfg "memmap=0x77ffffff$0x880000000", the result of
> "cat /proc/cmdline" changed to "memmap=0x77ffffffx880000000".
> 
> I didn't find the root cause, I think maybe grub reserved "$0" as something
> special.
> Replace '$' with '%' in kernel boot parameter can fix this issue.

NAK for the reasons already discussed.

	-hpa


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	hpa@linux.intel.com, yinghai@kernel.org, jacob.shin@amd.com,
	konrad.wilk@oracle.com, linux-mm@kvack.org,
	Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH] x86: e820: fix memmap kernel boot parameter
Date: Fri, 30 Aug 2013 13:39:48 -0700	[thread overview]
Message-ID: <52210314.4080408@zytor.com> (raw)
In-Reply-To: <1377841673-17361-1-git-send-email-bob.liu@oracle.com>

On 08/29/2013 10:47 PM, Bob Liu wrote:
> Kernel boot parameter memmap=nn[KMG]$ss[KMG] is used to mark specific memory as
> reserved. Region of memory to be used is from ss to ss+nn.
> 
> But I found the action of this parameter is not as expected.
> I tried on two machines.
> Machine1: bootcmdline in grub.cfg "memmap=800M$0x60bfdfff", but the result of
> "cat /proc/cmdline" changed to "memmap=800M/bin/bashx60bfdfff" after system
> booted.
> 
> Machine2: bootcmdline in grub.cfg "memmap=0x77ffffff$0x880000000", the result of
> "cat /proc/cmdline" changed to "memmap=0x77ffffffx880000000".
> 
> I didn't find the root cause, I think maybe grub reserved "$0" as something
> special.
> Replace '$' with '%' in kernel boot parameter can fix this issue.

NAK for the reasons already discussed.

	-hpa



  parent reply	other threads:[~2013-08-30 20:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  5:47 [PATCH] x86: e820: fix memmap kernel boot parameter Bob Liu
2013-08-30  5:47 ` Bob Liu
2013-08-30  6:14 ` Dan Aloni
2013-08-30  6:14   ` Dan Aloni
2013-08-30  6:15   ` Bob Liu
2013-08-30  6:15     ` Bob Liu
2013-08-30 20:39 ` H. Peter Anvin [this message]
2013-08-30 20:39   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52210314.4080408@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=bob.liu@oracle.com \
    --cc=hpa@linux.intel.com \
    --cc=jacob.shin@amd.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lliubbo@gmail.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.