All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Krupa <JKrupa@suse.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-trivial] [PATCH 2/3] qemu-char: add Czech keymap file
Date: Sun, 01 Sep 2013 19:19:10 +0400	[thread overview]
Message-ID: <52235AEE.10103@msgid.tls.msk.ru> (raw)
In-Reply-To: <1377616488-16491-3-git-send-email-JKrupa@suse.com>

27.08.2013 19:14, Jan Krupa wrote:
> This patch adds Czech keyboard layout to available keymap files.
>
> Signed-off-by: Jan Krupa <jkrupa@suse.com>
> ---
>   pc-bios/keymaps/cz |   94 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 94 insertions(+), 0 deletions(-)
>   create mode 100644 pc-bios/keymaps/cz

This file is useles without a corresponding change to Makefile
(search for KEYMAPS= there).  Please add it there as well (either
in a separate patch or include it into this one).

Speaking of the keymap itself, and of the chars added in patch1,
I for one can't verify these, so I take it as granted.  After
all, this appears to be first attempt to implement cz keymap
in all these years...

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Krupa <JKrupa@suse.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] qemu-char: add Czech keymap file
Date: Sun, 01 Sep 2013 19:19:10 +0400	[thread overview]
Message-ID: <52235AEE.10103@msgid.tls.msk.ru> (raw)
In-Reply-To: <1377616488-16491-3-git-send-email-JKrupa@suse.com>

27.08.2013 19:14, Jan Krupa wrote:
> This patch adds Czech keyboard layout to available keymap files.
>
> Signed-off-by: Jan Krupa <jkrupa@suse.com>
> ---
>   pc-bios/keymaps/cz |   94 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 94 insertions(+), 0 deletions(-)
>   create mode 100644 pc-bios/keymaps/cz

This file is useles without a corresponding change to Makefile
(search for KEYMAPS= there).  Please add it there as well (either
in a separate patch or include it into this one).

Speaking of the keymap itself, and of the chars added in patch1,
I for one can't verify these, so I take it as granted.  After
all, this appears to be first attempt to implement cz keymap
in all these years...

Thanks,

/mjt

  parent reply	other threads:[~2013-09-01 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 15:14 [Qemu-trivial] [PATCH 0/3] qemu-char: keymap changes for Czech and Unicode support Jan Krupa
2013-08-27 15:14 ` [Qemu-devel] " Jan Krupa
2013-08-27 15:14 ` [Qemu-trivial] [PATCH 1/3] qemu-char: add Czech characters to VNC keysyms Jan Krupa
2013-08-27 15:14   ` [Qemu-devel] " Jan Krupa
2013-08-27 15:14   ` [Qemu-trivial] [PATCH 2/3] qemu-char: add Czech keymap file Jan Krupa
2013-08-27 15:14     ` [Qemu-devel] " Jan Krupa
2013-08-27 15:14     ` [Qemu-trivial] [PATCH 3/3] qemu-char: add support for U-prefixed symbols Jan Krupa
2013-08-27 15:14       ` [Qemu-devel] " Jan Krupa
2013-09-01 15:23       ` [Qemu-trivial] " Michael Tokarev
2013-09-01 15:23         ` [Qemu-devel] " Michael Tokarev
2013-09-01 15:19     ` Michael Tokarev [this message]
2013-09-01 15:19       ` [Qemu-devel] [Qemu-trivial] [PATCH 2/3] qemu-char: add Czech keymap file Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52235AEE.10103@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=JKrupa@suse.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.