All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <weil@mail.berlios.de>,
	Taimoor <taimoor.mrza@gmail.com>,
	Taimoor Mirza <tmirza@codesourcery.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows
Date: Sun, 01 Sep 2013 19:46:14 +0400	[thread overview]
Message-ID: <52236146.3050801@msgid.tls.msk.ru> (raw)
In-Reply-To: <52207C25.9070302@siemens.com>

30.08.2013 15:04, Jan Kiszka wrote:
> On 2013-08-15 21:25, Taimoor wrote:
>> From: Taimoor Mirza <tmirza@codesourcery.com>
>>
>> port redirection code uses SO_REUSEADDR socket option before binding to
>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>> Relaunching QEMU with same host and guest port redirection values on Linux
>> throws error but on Windows it does not throw any error.
>> Problem is discussed in http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
[]
> Stefan, can you ack this? Then I would pick it up for the slirp queue.

I remember having exactly the same issue myself a few years back with
the difference of SO_REUSEADDR behavour on windows and *nix, and the
suggested change appears to be correct.  So you can count on my

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

as well.

I applied the v2 of this patch (with a trivial fix) to trivial queue
(before seeing this v3), I can remove it if you like.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <weil@mail.berlios.de>,
	Taimoor <taimoor.mrza@gmail.com>,
	Taimoor Mirza <tmirza@codesourcery.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows
Date: Sun, 01 Sep 2013 19:46:14 +0400	[thread overview]
Message-ID: <52236146.3050801@msgid.tls.msk.ru> (raw)
In-Reply-To: <52207C25.9070302@siemens.com>

30.08.2013 15:04, Jan Kiszka wrote:
> On 2013-08-15 21:25, Taimoor wrote:
>> From: Taimoor Mirza <tmirza@codesourcery.com>
>>
>> port redirection code uses SO_REUSEADDR socket option before binding to
>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>> Relaunching QEMU with same host and guest port redirection values on Linux
>> throws error but on Windows it does not throw any error.
>> Problem is discussed in http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
[]
> Stefan, can you ack this? Then I would pick it up for the slirp queue.

I remember having exactly the same issue myself a few years back with
the difference of SO_REUSEADDR behavour on windows and *nix, and the
suggested change appears to be correct.  So you can count on my

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

as well.

I applied the v2 of this patch (with a trivial fix) to trivial queue
(before seeing this v3), I can remove it if you like.

Thanks,

/mjt

  reply	other threads:[~2013-09-01 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 19:25 [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows Taimoor
2013-08-15 19:25 ` [Qemu-devel] " Taimoor
2013-08-30 11:04 ` [Qemu-trivial] " Jan Kiszka
2013-08-30 11:04   ` [Qemu-devel] " Jan Kiszka
2013-09-01 15:46   ` Michael Tokarev [this message]
2013-09-01 15:46     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-09-01 16:13     ` Stefan Weil
2013-09-01 16:13       ` [Qemu-devel] " Stefan Weil
2013-09-02  1:36       ` Mirza, Taimoor
2013-09-02  1:36         ` [Qemu-devel] " Mirza, Taimoor
2013-09-02  6:18       ` Jan Kiszka
2013-09-02  6:18         ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52236146.3050801@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=taimoor.mrza@gmail.com \
    --cc=tmirza@codesourcery.com \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.