From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: dmitry.torokhov@gmail.com, Bill Pemberton <wfp5p@virginia.edu>,
broonie@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put
Date: Sun, 1 Sep 2013 20:01:31 +0300 [thread overview]
Message-ID: <522372EB.1060701@ti.com> (raw)
In-Reply-To: <522190ED.6020909@huawei.com>
On 08/31/2013 09:45 AM, Libo Chen wrote:
>
> decrease node device_node refcount after task completion
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/input/misc/twl4030-vibra.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
> index 68a5f33..b8d1526 100644
> --- a/drivers/input/misc/twl4030-vibra.c
> +++ b/drivers/input/misc/twl4030-vibra.c
> @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
> if (pdata && pdata->coexist)
> return true;
>
> - if (of_find_node_by_name(node, "codec"))
> + if (of_find_node_by_name(node, "codec")) {
> + of_node_put(node);
> return true;
> + }
>
> return false;
> }
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: <dmitry.torokhov@gmail.com>, Bill Pemberton <wfp5p@virginia.edu>,
<broonie@opensource.wolfsonmicro.com>,
<linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put
Date: Sun, 1 Sep 2013 20:01:31 +0300 [thread overview]
Message-ID: <522372EB.1060701@ti.com> (raw)
In-Reply-To: <522190ED.6020909@huawei.com>
On 08/31/2013 09:45 AM, Libo Chen wrote:
>
> decrease node device_node refcount after task completion
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/input/misc/twl4030-vibra.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
> index 68a5f33..b8d1526 100644
> --- a/drivers/input/misc/twl4030-vibra.c
> +++ b/drivers/input/misc/twl4030-vibra.c
> @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
> if (pdata && pdata->coexist)
> return true;
>
> - if (of_find_node_by_name(node, "codec"))
> + if (of_find_node_by_name(node, "codec")) {
> + of_node_put(node);
> return true;
> + }
>
> return false;
> }
>
--
Péter
next prev parent reply other threads:[~2013-09-01 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 6:45 [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put Libo Chen
2013-08-31 6:45 ` Libo Chen
2013-09-01 17:01 ` Peter Ujfalusi [this message]
2013-09-01 17:01 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522372EB.1060701@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clbchenlibo.chen@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.