* [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig
@ 2013-09-01 17:38 John Crispin
2013-09-01 18:44 ` Gabor Juhos
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2013-09-01 17:38 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, John Crispin
Without this symbol being set, we get an undefined symbol compile error.
Signed-off-by: John Crispin <blogic@openwrt.org>
---
arch/mips/configs/rt305x_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/configs/rt305x_defconfig b/arch/mips/configs/rt305x_defconfig
index d1741bc..a222319 100644
--- a/arch/mips/configs/rt305x_defconfig
+++ b/arch/mips/configs/rt305x_defconfig
@@ -131,6 +131,7 @@ CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
CONFIG_STAGING=y
# CONFIG_IOMMU_SUPPORT is not set
+CONFIG_RESET_CONTROLLER=y
# CONFIG_DNOTIFY is not set
# CONFIG_PROC_PAGE_MONITOR is not set
CONFIG_TMPFS=y
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig
2013-09-01 17:38 [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig John Crispin
@ 2013-09-01 18:44 ` Gabor Juhos
2013-09-01 18:48 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Gabor Juhos @ 2013-09-01 18:44 UTC (permalink / raw)
To: John Crispin; +Cc: Ralf Baechle, linux-mips
2013.09.01. 19:38 keltezéssel, John Crispin írta:
> Without this symbol being set, we get an undefined symbol compile error.
The reset framework is unconditionally used by the ralink platform code. So I
assume that the compile error is also present on rt288x, rt3883 and mt7620.
Maybe it would be better to add a 'select RESET_CONTROLLER' for the RALINK
symbol in 'arch/mips/Kconfig'?
BTW, I have looked into your 'MIPS: ralink: add support for reset-controller
API' patch [1] again. That adds a 'select ARCH_HAS_RESET_CONTROLLER' to the
MACH_VR41XX symbol instead of RALINK.
-Gabor
1. https://patchwork.linux-mips.org/patch/5668/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig
2013-09-01 18:44 ` Gabor Juhos
@ 2013-09-01 18:48 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2013-09-01 18:48 UTC (permalink / raw)
To: linux-mips
On 01/09/13 20:44, Gabor Juhos wrote:
> 2013.09.01. 19:38 keltezéssel, John Crispin írta:
>> Without this symbol being set, we get an undefined symbol compile error.
>
> The reset framework is unconditionally used by the ralink platform code. So I
> assume that the compile error is also present on rt288x, rt3883 and mt7620.
>
> Maybe it would be better to add a 'select RESET_CONTROLLER' for the RALINK
> symbol in 'arch/mips/Kconfig'?
>
> BTW, I have looked into your 'MIPS: ralink: add support for reset-controller
> API' patch [1] again. That adds a 'select ARCH_HAS_RESET_CONTROLLER' to the
> MACH_VR41XX symbol instead of RALINK.
>
thanks, i will look into it
John
> -Gabor
>
> 1. https://patchwork.linux-mips.org/patch/5668/
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-01 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-01 17:38 [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig John Crispin
2013-09-01 18:44 ` Gabor Juhos
2013-09-01 18:48 ` John Crispin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.