From: George Cherian <george.cherian@ti.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
n.a.balandin@gmail.com
Subject: Re: [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq
Date: Mon, 2 Sep 2013 07:32:16 +0530 [thread overview]
Message-ID: <5223F1A8.4090509@ti.com> (raw)
In-Reply-To: <87ppssrpci.wl%kuninori.morimoto.gx@renesas.com>
On 9/2/2013 6:50 AM, Kuninori Morimoto wrote:
> Hi
>
>> Remove the request_irq and use devm_request_threaded_irq
>> also cleanup free_irq. devm_* takes care of that.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 2 +-
>> drivers/gpio/gpio-pcf857x.c | 28 ++++++++++++++++++++++++----
>> 2 files changed, 25 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 8b0738a..39b44bc 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -65,7 +65,7 @@
>> n_latch = <0x1408>;
>> gpio-controller;
>> #gpio-cells = <2>;
>> - interrupt-parent = <&pcf_20>;
>> + interrupt-parent = <&gpio20>;
>> interrupts = <14 2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
> I'm not sure detail,
> but does above "exchange interrupt-parent" and "using devm_request_threaded_irq()"
> have any relationship ?
Exactly. will resend this change alone.
> Separate patch seems nice ?
okay
> Best regards
> ---
> Kuninori Morimoto
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<n.a.balandin@gmail.com>
Subject: Re: [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq
Date: Mon, 2 Sep 2013 07:32:16 +0530 [thread overview]
Message-ID: <5223F1A8.4090509@ti.com> (raw)
In-Reply-To: <87ppssrpci.wl%kuninori.morimoto.gx@renesas.com>
On 9/2/2013 6:50 AM, Kuninori Morimoto wrote:
> Hi
>
>> Remove the request_irq and use devm_request_threaded_irq
>> also cleanup free_irq. devm_* takes care of that.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 2 +-
>> drivers/gpio/gpio-pcf857x.c | 28 ++++++++++++++++++++++++----
>> 2 files changed, 25 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 8b0738a..39b44bc 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -65,7 +65,7 @@
>> n_latch = <0x1408>;
>> gpio-controller;
>> #gpio-cells = <2>;
>> - interrupt-parent = <&pcf_20>;
>> + interrupt-parent = <&gpio20>;
>> interrupts = <14 2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
> I'm not sure detail,
> but does above "exchange interrupt-parent" and "using devm_request_threaded_irq()"
> have any relationship ?
Exactly. will resend this change alone.
> Separate patch seems nice ?
okay
> Best regards
> ---
> Kuninori Morimoto
--
-George
next prev parent reply other threads:[~2013-09-02 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 10:48 [PATCH v2 0/3] cleanup of gpio_pcf857x.c George Cherian
2013-08-30 10:48 ` George Cherian
2013-08-30 10:48 ` [PATCH v2 1/3] gpio: pcf857x: change to devm_request_threaded_irq George Cherian
2013-08-30 10:48 ` George Cherian
2013-09-02 1:20 ` Kuninori Morimoto
2013-09-02 2:02 ` George Cherian [this message]
2013-09-02 2:02 ` George Cherian
2013-08-30 10:48 ` [PATCH v2 2/3] gpio: pcf857x: remove the irq_demux_work George Cherian
2013-08-30 10:48 ` George Cherian
2013-08-30 10:48 ` [PATCH v2 3/3] gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done George Cherian
2013-08-30 10:48 ` George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5223F1A8.4090509@ti.com \
--to=george.cherian@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=n.a.balandin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.