Re: [PATCH] MIPS: powertv: Drop BOOTLOADER_DRIVER Kconfig symbol

[Markos Chandras <Markos.Chandras@imgtec.com>]

On 09/01/13 18:42, John Crispin wrote:
> On 21/08/13 10:53, Markos Chandras wrote:
>> The kbldr.h header file required for this was neither committed in the
>> original submission in a3a0f8c8ed2e2470f4dcd6da95020d41fed84747
>> "MIPS: PowerTV: Base files for Cisco PowerTV platform"
>> nor it was ever present in the git tree so this option never worked.
>> Fixes the following build problem:
>> arch/mips/powertv/reset.c:25:36: fatal error:
>> asm/mach-powertv/kbldr.h: No such
>> file or directory
>> compilation terminated.
>>
>> Signed-off-by: Markos Chandras<markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill<Steven.Hill@imgtec.com>
>> ---
>> This patch is for the upstream-sfr/mips-for-linux-next tree
>> ---
>>   arch/mips/Kconfig                     |  1 +
>>   arch/mips/powertv/Kconfig             |  9 +--------
>>   arch/mips/powertv/asic/asic_devices.c | 15 +++------------
>>   arch/mips/powertv/init.c              |  4 ----
>>   arch/mips/powertv/reset.c             | 12 ------------
>>   5 files changed, 5 insertions(+), 36 deletions(-)
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index e12764c..d08a3a6 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -416,6 +416,7 @@ config PMC_MSP
>>   config POWERTV
>>       bool "Cisco PowerTV"
>>       select BOOT_ELF32
>> +    select BOOTLOADER_FAMILY
>>       select CEVT_R4K
>>       select CPU_MIPSR2_IRQ_VI
>>       select CPU_MIPSR2_IRQ_EI
>
> Hi,
>
> BOOTLOADER_FAMILY is a string causing the select to spew this error
>
> -> arch/mips/Kconfig:420:warning: 'BOOTLOADER_FAMILY' has wrong type.
> 'select' only accept arguments of boolean and tristate type
>
>      John

Hi John,

Hmm strange I haven't seen this problem when I tested this patch. I will 
double check and submit a new patch.