* [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice @ 2013-09-03 3:00 ` Wanpeng Li 0 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li Changelog: * rebase against mmotm tree The caller address has already been set in set_vmalloc_vm(), there's no need to set it again in __vmalloc_area_node. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 1074543..d78d117 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, pages = kmalloc_node(array_size, nested_gfp, node); } area->pages = pages; - area->caller = caller; if (!area->pages) { remove_vm_area(area->addr); kfree(area); -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice @ 2013-09-03 3:00 ` Wanpeng Li 0 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li Changelog: * rebase against mmotm tree The caller address has already been set in set_vmalloc_vm(), there's no need to set it again in __vmalloc_area_node. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 1074543..d78d117 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, pages = kmalloc_node(array_size, nested_gfp, node); } area->pages = pages; - area->caller = caller; if (!area->pages) { remove_vm_area(area->addr); kfree(area); -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice 2013-09-03 3:00 ` Wanpeng Li @ 2013-09-03 3:00 ` Wanpeng Li -1 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li Don't warning twice in __vmalloc_area_node and __vmalloc_node_range if __vmalloc_area_node allocation failure. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d78d117..e3ec8b4 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1635,7 +1635,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); if (!addr) - goto fail; + return NULL; /* * In this function, newly allocated vm_struct has VM_UNINITIALIZED -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice @ 2013-09-03 3:00 ` Wanpeng Li 0 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li Don't warning twice in __vmalloc_area_node and __vmalloc_node_range if __vmalloc_area_node allocation failure. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d78d117..e3ec8b4 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1635,7 +1635,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); if (!addr) - goto fail; + return NULL; /* * In this function, newly allocated vm_struct has VM_UNINITIALIZED -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice 2013-09-03 3:00 ` Wanpeng Li @ 2013-09-03 5:38 ` Zhang Yanfei -1 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:38 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > Don't warning twice in __vmalloc_area_node and __vmalloc_node_range if > __vmalloc_area_node allocation failure. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> OK, I missed the warning in __vmalloc_area_node(), so you are right. You can just revert the commit 46c001a2753f47ffa621131baa3409e636515347. > --- > mm/vmalloc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d78d117..e3ec8b4 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1635,7 +1635,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > > addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); > if (!addr) > - goto fail; > + return NULL; > > /* > * In this function, newly allocated vm_struct has VM_UNINITIALIZED > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice @ 2013-09-03 5:38 ` Zhang Yanfei 0 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:38 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > Don't warning twice in __vmalloc_area_node and __vmalloc_node_range if > __vmalloc_area_node allocation failure. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> OK, I missed the warning in __vmalloc_area_node(), so you are right. You can just revert the commit 46c001a2753f47ffa621131baa3409e636515347. > --- > mm/vmalloc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d78d117..e3ec8b4 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1635,7 +1635,7 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > > addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); > if (!addr) > - goto fail; > + return NULL; > > /* > * In this function, newly allocated vm_struct has VM_UNINITIALIZED > -- Thanks. Zhang Yanfei ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info 2013-09-03 3:00 ` Wanpeng Li @ 2013-09-03 3:00 ` Wanpeng Li -1 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid accessing the pages field with unallocated page when show_numa_info() is called. This patch move the check just before show_numa_info in order that some messages still can be dumped via /proc/vmallocinfo. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e3ec8b4..c4720cd 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) v = va->vm; - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ - smp_rmb(); - if (v->flags & VM_UNINITIALIZED) - return 0; - seq_printf(m, "0x%pK-0x%pK %7ld", v->addr, v->addr + v->size, v->size); @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) if (v->flags & VM_VPAGES) seq_printf(m, " vpages"); + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ + smp_rmb(); + if (v->flags & VM_UNINITIALIZED) + return 0; + show_numa_info(m, v); seq_putc(m, '\n'); return 0; -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info @ 2013-09-03 3:00 ` Wanpeng Li 0 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 3:00 UTC (permalink / raw) To: Andrew Morton Cc: Joonsoo Kim, David Rientjes, KOSAKI Motohiro, Zhang Yanfei, linux-mm, linux-kernel, Wanpeng Li The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid accessing the pages field with unallocated page when show_numa_info() is called. This patch move the check just before show_numa_info in order that some messages still can be dumped via /proc/vmallocinfo. Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> --- mm/vmalloc.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e3ec8b4..c4720cd 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) v = va->vm; - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ - smp_rmb(); - if (v->flags & VM_UNINITIALIZED) - return 0; - seq_printf(m, "0x%pK-0x%pK %7ld", v->addr, v->addr + v->size, v->size); @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) if (v->flags & VM_VPAGES) seq_printf(m, " vpages"); + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ + smp_rmb(); + if (v->flags & VM_UNINITIALIZED) + return 0; + show_numa_info(m, v); seq_putc(m, '\n'); return 0; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info 2013-09-03 3:00 ` Wanpeng Li @ 2013-09-03 5:40 ` Zhang Yanfei -1 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:40 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid > null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid > accessing the pages field with unallocated page when show_numa_info() is > called. This patch move the check just before show_numa_info in order that > some messages still can be dumped via /proc/vmallocinfo. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> Hmmm, sorry again. Please revert commit d157a55815ffff48caec311dfb543ce8a79e283e. That said, we could still do the check in show_numa_info like before. > --- > mm/vmalloc.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e3ec8b4..c4720cd 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) > > v = va->vm; > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > - smp_rmb(); > - if (v->flags & VM_UNINITIALIZED) > - return 0; > - > seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); > > @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) > if (v->flags & VM_VPAGES) > seq_printf(m, " vpages"); > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > + smp_rmb(); > + if (v->flags & VM_UNINITIALIZED) > + return 0; > + > show_numa_info(m, v); > seq_putc(m, '\n'); > return 0; > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info @ 2013-09-03 5:40 ` Zhang Yanfei 0 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:40 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid > null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid > accessing the pages field with unallocated page when show_numa_info() is > called. This patch move the check just before show_numa_info in order that > some messages still can be dumped via /proc/vmallocinfo. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> Hmmm, sorry again. Please revert commit d157a55815ffff48caec311dfb543ce8a79e283e. That said, we could still do the check in show_numa_info like before. > --- > mm/vmalloc.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e3ec8b4..c4720cd 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) > > v = va->vm; > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > - smp_rmb(); > - if (v->flags & VM_UNINITIALIZED) > - return 0; > - > seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); > > @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) > if (v->flags & VM_VPAGES) > seq_printf(m, " vpages"); > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > + smp_rmb(); > + if (v->flags & VM_UNINITIALIZED) > + return 0; > + > show_numa_info(m, v); > seq_putc(m, '\n'); > return 0; > -- Thanks. Zhang Yanfei ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info 2013-09-03 5:40 ` Zhang Yanfei (?) @ 2013-09-03 6:00 ` Wanpeng Li -1 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 6:00 UTC (permalink / raw) To: Zhang Yanfei Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On Tue, Sep 03, 2013 at 01:40:46PM +0800, Zhang Yanfei wrote: >On 09/03/2013 11:00 AM, Wanpeng Li wrote: >> The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid >> null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid >> accessing the pages field with unallocated page when show_numa_info() is >> called. This patch move the check just before show_numa_info in order that >> some messages still can be dumped via /proc/vmallocinfo. >> >> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> > >Hmmm, sorry again. Please revert commit >d157a55815ffff48caec311dfb543ce8a79e283e. That said, we could still >do the check in show_numa_info like before. > Ok. Regards, Wanpeng Li >> --- >> mm/vmalloc.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index e3ec8b4..c4720cd 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) >> >> v = va->vm; >> >> - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ >> - smp_rmb(); >> - if (v->flags & VM_UNINITIALIZED) >> - return 0; >> - >> seq_printf(m, "0x%pK-0x%pK %7ld", >> v->addr, v->addr + v->size, v->size); >> >> @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) >> if (v->flags & VM_VPAGES) >> seq_printf(m, " vpages"); >> >> + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ >> + smp_rmb(); >> + if (v->flags & VM_UNINITIALIZED) >> + return 0; >> + >> show_numa_info(m, v); >> seq_putc(m, '\n'); >> return 0; >> > > >-- >Thanks. >Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info 2013-09-03 5:40 ` Zhang Yanfei (?) (?) @ 2013-09-03 6:00 ` Wanpeng Li -1 siblings, 0 replies; 14+ messages in thread From: Wanpeng Li @ 2013-09-03 6:00 UTC (permalink / raw) To: Zhang Yanfei Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On Tue, Sep 03, 2013 at 01:40:46PM +0800, Zhang Yanfei wrote: >On 09/03/2013 11:00 AM, Wanpeng Li wrote: >> The VM_UNINITIALIZED/VM_UNLIST flag introduced by commit f5252e00(mm: avoid >> null pointer access in vm_struct via /proc/vmallocinfo) is used to avoid >> accessing the pages field with unallocated page when show_numa_info() is >> called. This patch move the check just before show_numa_info in order that >> some messages still can be dumped via /proc/vmallocinfo. >> >> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> > >Hmmm, sorry again. Please revert commit >d157a55815ffff48caec311dfb543ce8a79e283e. That said, we could still >do the check in show_numa_info like before. > Ok. Regards, Wanpeng Li >> --- >> mm/vmalloc.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index e3ec8b4..c4720cd 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2590,11 +2590,6 @@ static int s_show(struct seq_file *m, void *p) >> >> v = va->vm; >> >> - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ >> - smp_rmb(); >> - if (v->flags & VM_UNINITIALIZED) >> - return 0; >> - >> seq_printf(m, "0x%pK-0x%pK %7ld", >> v->addr, v->addr + v->size, v->size); >> >> @@ -2622,6 +2617,11 @@ static int s_show(struct seq_file *m, void *p) >> if (v->flags & VM_VPAGES) >> seq_printf(m, " vpages"); >> >> + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ >> + smp_rmb(); >> + if (v->flags & VM_UNINITIALIZED) >> + return 0; >> + >> show_numa_info(m, v); >> seq_putc(m, '\n'); >> return 0; >> > > >-- >Thanks. >Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice 2013-09-03 3:00 ` Wanpeng Li @ 2013-09-03 5:34 ` Zhang Yanfei -1 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:34 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > Changelog: > * rebase against mmotm tree > > The caller address has already been set in set_vmalloc_vm(), there's no need > to set it again in __vmalloc_area_node. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > --- > mm/vmalloc.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 1074543..d78d117 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > pages = kmalloc_node(array_size, nested_gfp, node); > } > area->pages = pages; > - area->caller = caller; > if (!area->pages) { > remove_vm_area(area->addr); > kfree(area); > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice @ 2013-09-03 5:34 ` Zhang Yanfei 0 siblings, 0 replies; 14+ messages in thread From: Zhang Yanfei @ 2013-09-03 5:34 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Joonsoo Kim, David Rientjes, KOSAKI Motohiro, linux-mm, linux-kernel On 09/03/2013 11:00 AM, Wanpeng Li wrote: > Changelog: > * rebase against mmotm tree > > The caller address has already been set in set_vmalloc_vm(), there's no need > to set it again in __vmalloc_area_node. > > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > --- > mm/vmalloc.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 1074543..d78d117 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > pages = kmalloc_node(array_size, nested_gfp, node); > } > area->pages = pages; > - area->caller = caller; > if (!area->pages) { > remove_vm_area(area->addr); > kfree(area); > -- Thanks. Zhang Yanfei ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-09-03 6:01 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-03 3:00 [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice Wanpeng Li 2013-09-03 3:00 ` Wanpeng Li 2013-09-03 3:00 ` [PATCH v2 2/3] mm/vmalloc: don't warning vmalloc allocation failure twice Wanpeng Li 2013-09-03 3:00 ` Wanpeng Li 2013-09-03 5:38 ` Zhang Yanfei 2013-09-03 5:38 ` Zhang Yanfei 2013-09-03 3:00 ` [PATCH v2 3/3] mm/vmalloc: move VM_UNINITIALIZED just before show_numa_info Wanpeng Li 2013-09-03 3:00 ` Wanpeng Li 2013-09-03 5:40 ` Zhang Yanfei 2013-09-03 5:40 ` Zhang Yanfei 2013-09-03 6:00 ` Wanpeng Li 2013-09-03 6:00 ` Wanpeng Li 2013-09-03 5:34 ` [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice Zhang Yanfei 2013-09-03 5:34 ` Zhang Yanfei
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.