All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Per Dalén" <per.dalen@appeartv.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: netdev@vger.kernel.org
Subject: Re: BQL support in gianfar causes network hiccup
Date: Tue, 03 Sep 2013 09:55:09 +0200	[thread overview]
Message-ID: <522595DD.1030600@appeartv.com> (raw)
In-Reply-To: <52258A60.8040305@freescale.com>

On 09/03/2013 09:06 AM, Claudiu Manoil wrote:
> On 9/2/2013 7:50 PM, Per Dalén wrote:
>> On 09/02/2013 05:35 PM, Claudiu Manoil wrote:
>>> On 9/2/2013 5:37 PM, Per Dalén wrote:
>>>>> The proposed fix is currently under review:
>>>>> http://patchwork.ozlabs.org/patch/271242/
>>>>> "gianfar: Fix reported number of sent bytes to BQL"
>>>>>
>>>>> Does this one work for you? You might need to pull
>>>>> one recent gianfar clean-up patch from net-next in order
>>>>> to apply this one without incidents.
>>>>>
>>>>
>>>> No, still the same error:
>>>>
>>>> NETDEV WATCHDOG: eth0 (fsl-gianfar): transmit queue 0 timed out
>>>> ------------[ cut here ]------------
>>>> WARNING: at net/sched/sch_generic.c:256
>>>> Modules linked in:
>>>> NIP: c039ce0c LR: c039ce0c CTR: c02ef578
>>>> ...
>>>> 4e800421 80fe0244 4bffff40 7fc3f378 4bfea9d1 7fc4f378 7c651b78 3c60c055
>>>> 7fe6fb78 38635304 4cc63182 480fcddd <0fe00000> 39200001 993c0a3c
>>>> 4bffffb4
>>>> ---[ end trace 5f5e1e3c30024010 ]---
>>>>
>>>>
>>>
>>> Tried to reproduce the issue with a recent net-next kernel (Linux
>>> p2020rdb 3.11.0-rc6) + BQL fix patch (http://patchwork.ozlabs.org/patc
>>> /271242/), but the iperf test finished without incidents (see log
>>> below).
>>> Will try if the problem is apparent without the fix patch, on the same
>>> net-next kernel (3.11.0-rc6).
>>>
>>
>> I was able to reproduce it on our card and the P2020RDB using 3.11.0-rc7
>> + David Miller's -next networking tree and your patch
>> (http://patchwork.ozlabs.org/patch/271242/).
>>
>> root@p2020rdb:~# iperf -s
>
> Ok, I see, iperf -s on P2020. This way I was able to get the tx timeout
> too.  With iperf -c on P2020 it doesn't come up.  Now it'll be
> interesting to find out what BQL/ BQL integration in gianfar has to do
> with this.

Yes, it's weird. The only reason I removed the BQL commit 
(d8a0f1b0af67679bba886784de10d8c21acc4e0e) was because the error Tino 
Keitel had was the similar as mine.

>
> Thanks.
> claudiu
>
>

Thanks,
Per

  reply	other threads:[~2013-09-03  7:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02 13:21 BQL support in gianfar causes network hiccup Per Dalén
2013-09-02 13:53 ` Claudiu Manoil
2013-09-02 14:37   ` Per Dalén
2013-09-02 15:35     ` Claudiu Manoil
2013-09-02 16:50       ` Per Dalén
2013-09-03  7:06         ` Claudiu Manoil
2013-09-03  7:55           ` Per Dalén [this message]
2013-09-03 15:42             ` Eric Dumazet
2013-09-03 16:09               ` Claudiu Manoil
2013-09-03 19:33                 ` Per Dalén

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522595DD.1030600@appeartv.com \
    --to=per.dalen@appeartv.com \
    --cc=claudiu.manoil@freescale.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.