From: Stephen Warren <swarren@wwwdotorg.org>
To: wangyuhang <wangyuhang2014@gmail.com>
Cc: devicetree@vger.kernel.org, tomasz.figa@gmail.com,
linux-spi@vger.kernel.org, broonie@kernel.org,
linux-mtd@lists.infradead.org, pekon@ti.com
Subject: Re: [PATCH] spi: quad: fix the name of DT property
Date: Tue, 03 Sep 2013 10:53:11 -0600 [thread overview]
Message-ID: <522613F7.908@wwwdotorg.org> (raw)
In-Reply-To: <1378028181-5409-1-git-send-email-wangyuhang2014@gmail.com>
On 09/01/2013 03:36 AM, wangyuhang wrote:
> spi: quad: fix the name of DT property in patch
>
> The previous property name spi-tx-nbits and spi-rx-nbits looks not
> human-readable. To make it consistent with other devices, using property
> name spi-tx-bus-width and spi-rx-bus-width instead of the previous one
> specify the number of data wires that spi controller will work in.
> Add the specification in spi-bus.txt.
> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
> - spi-3wire - (optional) Empty property indicating device requires
> 3-wire mode.
> +- spi-tx-bus-width - (optional) The bus width(number of data wires) that
> + used for MOSI. Defaults to 1 if not present.
> +- spi-rx-bus-width - (optional) The bus width(number of data wires) that
> + used for MISO. Defaults to 1 if not present.
The binding,
Acked-by: Stephen Warren <swarren@nvidia.com>
I would have preferred my original wording rather than the unqualified
"MOSI"/"MISO", since the meaning of those terms depends on whether
you're looking at the host controller or the device, but I guess we can
assume that since this is documentation for the host controller binding,
the naming is in terms of the host controller's signals.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: wangyuhang <wangyuhang2014@gmail.com>
Cc: devicetree@vger.kernel.org, tomasz.figa@gmail.com,
linux-spi@vger.kernel.org, broonie@kernel.org,
linux-mtd@lists.infradead.org, pekon@ti.com
Subject: Re: [PATCH] spi: quad: fix the name of DT property
Date: Tue, 03 Sep 2013 10:53:11 -0600 [thread overview]
Message-ID: <522613F7.908@wwwdotorg.org> (raw)
In-Reply-To: <1378028181-5409-1-git-send-email-wangyuhang2014@gmail.com>
On 09/01/2013 03:36 AM, wangyuhang wrote:
> spi: quad: fix the name of DT property in patch
>
> The previous property name spi-tx-nbits and spi-rx-nbits looks not
> human-readable. To make it consistent with other devices, using property
> name spi-tx-bus-width and spi-rx-bus-width instead of the previous one
> specify the number of data wires that spi controller will work in.
> Add the specification in spi-bus.txt.
> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
> - spi-3wire - (optional) Empty property indicating device requires
> 3-wire mode.
> +- spi-tx-bus-width - (optional) The bus width(number of data wires) that
> + used for MOSI. Defaults to 1 if not present.
> +- spi-rx-bus-width - (optional) The bus width(number of data wires) that
> + used for MISO. Defaults to 1 if not present.
The binding,
Acked-by: Stephen Warren <swarren@nvidia.com>
I would have preferred my original wording rather than the unqualified
"MOSI"/"MISO", since the meaning of those terms depends on whether
you're looking at the host controller or the device, but I guess we can
assume that since this is documentation for the host controller binding,
the naming is in terms of the host controller's signals.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2013-09-03 16:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 10:15 [PATCH v3 1/2]spi: DUAL and QUAD support wangyuhang
2013-08-11 10:15 ` wangyuhang
2013-08-22 12:30 ` Mark Brown
2013-08-22 12:30 ` Mark Brown
2013-08-22 12:30 ` Mark Brown
2013-08-22 12:35 ` Sourav Poddar
2013-08-22 12:35 ` Sourav Poddar
2013-08-22 13:21 ` Mark Brown
2013-08-22 13:21 ` Mark Brown
2013-08-22 14:23 ` Sourav Poddar
2013-08-22 14:23 ` Sourav Poddar
2013-08-22 12:37 ` Mark Brown
2013-08-22 12:37 ` Mark Brown
2013-09-01 9:36 ` [PATCH] spi: quad: fix the name of DT property wangyuhang
2013-09-01 9:36 ` wangyuhang
2013-09-01 12:46 ` Mark Brown
2013-09-01 12:46 ` Mark Brown
2013-09-03 16:53 ` Stephen Warren [this message]
2013-09-03 16:53 ` Stephen Warren
2013-09-03 23:01 ` Mark Brown
2013-09-03 23:01 ` Mark Brown
2013-09-04 3:24 ` [PATCH v3 1/2]spi: DUAL and QUAD support Trent Piepho
2013-09-04 3:24 ` Trent Piepho
2013-09-04 7:07 ` yuhang wang
2013-09-04 7:07 ` yuhang wang
2013-09-25 23:33 ` Trent Piepho
2013-09-25 23:33 ` Trent Piepho
[not found] ` <CA+7tXigzKW8sydfnktr4F5uY-SKk0JAMjaxFn74XLbw_NTYVXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-25 23:52 ` [PATCH 1/4] spi: Use of_property_read_u32 Trent Piepho
2013-09-26 6:12 ` Sourav Poddar
2013-09-25 23:52 ` [PATCH 2/4] spi: Order fields in spi_device for better packing Trent Piepho
2013-09-26 6:14 ` Sourav Poddar
2013-09-25 23:52 ` [PATCH 3/4] spi: Encode data width more efficiently Trent Piepho
2013-09-26 6:14 ` Sourav Poddar
2013-09-25 23:52 ` [PATCH 4/4] spi: Simplify bit width checking code Trent Piepho
2013-09-26 6:14 ` Sourav Poddar
2013-09-04 9:45 ` [PATCH v3 1/2]spi: DUAL and QUAD support Mark Brown
2013-09-04 9:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522613F7.908@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=pekon@ti.com \
--cc=tomasz.figa@gmail.com \
--cc=wangyuhang2014@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.