All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tang Chen <tangchen@cn.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
	hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org,
	trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com,
	wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
	isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
	mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
	gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
	lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
	prarit@redhat.com, zhangyanfei@cn.fujitsu.com, x86@kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 06/11] memblock: Improve memblock to support allocation from lower address.
Date: Wed, 04 Sep 2013 09:00:36 +0800	[thread overview]
Message-ID: <52268634.1050008@cn.fujitsu.com> (raw)
In-Reply-To: <1378254257.10300.921.camel@misato.fc.hp.com>

On 09/04/2013 08:24 AM, Toshi Kani wrote:
......
>> +phys_addr_t __init_memblock
>> +__memblock_find_range(phys_addr_t start, phys_addr_t end,
>> +		      phys_addr_t size, phys_addr_t align, int nid)
>
> This func should be static as it must be an internal func.
>
......
>> +phys_addr_t __init_memblock
>> +__memblock_find_range_rev(phys_addr_t start, phys_addr_t end,
>> +			  phys_addr_t size, phys_addr_t align, int nid)
>
> Ditto.
......
>> +	if (memblock.current_order == MEMBLOCK_ORDER_DEFAULT)
>
> This needs to use MEMBLOCK_ORDER_HIGH_TO_LOW since the code should be
> independent from the value of MEMBLOCK_ORDER_DEFAULT.
>

OK, followed.

Thanks.


WARNING: multiple messages have this Message-ID (diff)
From: Tang Chen <tangchen@cn.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
	hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org,
	trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com,
	wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
	isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
	mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
	gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
	lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
	prarit@redhat.com, zhangyanfei@cn.fujitsu.com, x86@kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 06/11] memblock: Improve memblock to support allocation from lower address.
Date: Wed, 04 Sep 2013 09:00:36 +0800	[thread overview]
Message-ID: <52268634.1050008@cn.fujitsu.com> (raw)
In-Reply-To: <1378254257.10300.921.camel@misato.fc.hp.com>

On 09/04/2013 08:24 AM, Toshi Kani wrote:
......
>> +phys_addr_t __init_memblock
>> +__memblock_find_range(phys_addr_t start, phys_addr_t end,
>> +		      phys_addr_t size, phys_addr_t align, int nid)
>
> This func should be static as it must be an internal func.
>
......
>> +phys_addr_t __init_memblock
>> +__memblock_find_range_rev(phys_addr_t start, phys_addr_t end,
>> +			  phys_addr_t size, phys_addr_t align, int nid)
>
> Ditto.
......
>> +	if (memblock.current_order == MEMBLOCK_ORDER_DEFAULT)
>
> This needs to use MEMBLOCK_ORDER_HIGH_TO_LOW since the code should be
> independent from the value of MEMBLOCK_ORDER_DEFAULT.
>

OK, followed.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-09-04  1:00 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  9:37 [PATCH 00/11] x86, memblock: Allocate memory near kernel image before SRAT parsed Tang Chen
2013-08-27  9:37 ` Tang Chen
2013-08-27  9:37 ` [PATCH 01/11] memblock: Rename current_limit to current_limit_high in memblock Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-27  9:37 ` [PATCH 02/11] memblock: Rename memblock_set_current_limit() to memblock_set_current_limit_high() Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-27  9:37 ` [PATCH 03/11] memblock: Introduce lowest limit in memblock Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-27  9:37 ` [PATCH 04/11] memblock: Introduce memblock_set_current_limit_low() to set lower limit of memblock Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-27  9:37 ` [PATCH 05/11] memblock: Introduce allocation order to memblock Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-09-05  9:16   ` Wanpeng Li
2013-09-05  9:16   ` Wanpeng Li
2013-09-05  9:21     ` Tang Chen
2013-09-05  9:21       ` Tang Chen
2013-09-05  9:27       ` Wanpeng Li
2013-09-05  9:27       ` Wanpeng Li
2013-08-27  9:37 ` [PATCH 06/11] memblock: Improve memblock to support allocation from lower address Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-09-04  0:24   ` Toshi Kani
2013-09-04  0:24     ` Toshi Kani
2013-09-04  1:00     ` Tang Chen [this message]
2013-09-04  1:00       ` Tang Chen
2013-08-27  9:37 ` [PATCH 07/11] x86, memblock: Set lowest limit for memblock_alloc_base_nid() Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-09-04  0:37   ` Toshi Kani
2013-09-04  0:37     ` Toshi Kani
2013-09-04  2:05     ` Tang Chen
2013-09-04  2:05       ` Tang Chen
2013-09-04 15:22       ` Toshi Kani
2013-09-04 15:22         ` Toshi Kani
2013-08-27  9:37 ` [PATCH 08/11] x86, acpi, memblock: Use __memblock_alloc_base() in acpi_initrd_override() Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-28  0:04   ` Rafael J. Wysocki
2013-08-28  0:04     ` Rafael J. Wysocki
2013-08-27  9:37 ` [PATCH 09/11] mem-hotplug: Introduce movablenode boot option to {en|dis}able using SRAT Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-08-27  9:37 ` [PATCH 10/11] x86, mem-hotplug: Support initialize page tables from low to high Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-09-05 13:30   ` Wanpeng Li
2013-09-05 13:30   ` Wanpeng Li
2013-09-06  1:34     ` Tang Chen
2013-09-06  1:34       ` Tang Chen
2013-09-06  2:16       ` Wanpeng Li
2013-09-06  3:09         ` Tang Chen
2013-09-06  3:09           ` Tang Chen
2013-09-06  2:16       ` Wanpeng Li
2013-08-27  9:37 ` [PATCH 11/11] x86, mem_hotplug: Allocate memory near kernel image before SRAT is parsed Tang Chen
2013-08-27  9:37   ` Tang Chen
2013-09-04 19:40   ` Toshi Kani
2013-09-04 19:40     ` Toshi Kani
2013-08-28  8:03 ` [PATCH 00/11] x86, memblock: Allocate memory near kernel image before SRAT parsed Wanpeng Li
2013-08-28  9:34   ` Tang Chen
2013-08-28  9:34     ` Tang Chen
2013-08-28  8:03 ` Wanpeng Li
2013-08-28 15:19 ` Tejun Heo
2013-08-28 15:19   ` Tejun Heo
2013-08-29  1:30   ` Tang Chen
2013-08-29  1:30     ` Tang Chen
2013-08-29  1:36     ` Wanpeng Li
2013-08-29  1:53       ` Tang Chen
2013-08-29  1:53         ` Tang Chen
2013-08-29  1:36     ` Wanpeng Li
2013-09-02  1:03 ` Tang Chen
2013-09-02  1:03   ` Tang Chen
2013-09-04 19:22 ` Tejun Heo
2013-09-04 19:22   ` Tejun Heo
2013-09-05  9:01   ` Tang Chen
2013-09-05  9:01     ` Tang Chen
2013-09-06  8:58   ` Wanpeng Li
2013-09-06  8:58   ` Wanpeng Li
     [not found]   ` <52299935.0302450a.26c9.ffffb240SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-06 15:15     ` Tejun Heo
2013-09-06 15:15       ` Tejun Heo
2013-09-06 15:47       ` H. Peter Anvin
2013-09-06 15:47         ` H. Peter Anvin
2013-09-09 12:04         ` Wanpeng Li
2013-09-09 12:04         ` Wanpeng Li
2013-09-09 11:56       ` Wanpeng Li
2013-09-09 11:56       ` Wanpeng Li
     [not found]       ` <522db781.22ab440a.41b1.ffffd825SMTPIN_ADDED_BROKEN@mx.google.com>
2013-09-09 13:58         ` Tejun Heo
2013-09-09 13:58           ` Tejun Heo
2013-09-09 23:58           ` Wanpeng Li
2013-09-09 23:58           ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52268634.1050008@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=jweiner@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=toshi.kani@hp.com \
    --cc=trenn@suse.de \
    --cc=vasilis.liaskovitis@profitbricks.com \
    --cc=wency@cn.fujitsu.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.