From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock
Date: Wed, 04 Sep 2013 12:36:47 -0600 [thread overview]
Message-ID: <52277DBF.7080104@wwwdotorg.org> (raw)
In-Reply-To: <20130903232219.10934.67434@quantum>
On 09/03/2013 05:22 PM, Mike Turquette wrote:
> Quoting Stephen Warren (2013-08-30 14:37:46)
>> On 08/30/2013 02:33 PM, Mike Turquette wrote:
...
>>> The clock _data_ seems to always have some churn to it. Moving it out to
>>> DT reduces that churn from Linux. My concern above is not about kernel
>>> data size.
>>
>> That sounds like the opposite of what we should be doing.
>>
>> It's fine for kernel code/data to change; that's a natural part of
>> development. Obviously, we should minimize churn, through thorough
>> review, domain knowledge, etc.
>
> And with the "clock mapping" style bindings we'll end up changing both
> the DT binding definition and the kernel. Not great.
What's a "clock mapping" style binding? I guess that means the style
where you have a single DT node that provides multiple clocks, rather
than one DT node per clock?
If the kernel driver changes its internal data, I don't see why that
would have any impact at all on the DT binding definition. We should be
able to use one DT binding definition with arbitrary drivers.
> And I'll respond to your points below but the whole "relocate the
> problem to DT" argument is simply not my main point. What I want to do
> is increase the usefulness of DT by allowing register-level details into
> the binding which can
Can you expand upon why a DT that encodes register-level details is more
useful? I can't see why there would be any difference in usefulness.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mike Turquette <mturquette@linaro.org>
Cc: "Kumar Gala" <galak@codeaurora.org>,
devicetree@vger.kernel.org, "Heiko Stübner" <heiko@sntech.de>,
"Stephen Boyd" <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, "Tero Kristo" <t-kristo@ti.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Matt Sealey" <neko@bakuhatsu.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock
Date: Wed, 04 Sep 2013 12:36:47 -0600 [thread overview]
Message-ID: <52277DBF.7080104@wwwdotorg.org> (raw)
In-Reply-To: <20130903232219.10934.67434@quantum>
On 09/03/2013 05:22 PM, Mike Turquette wrote:
> Quoting Stephen Warren (2013-08-30 14:37:46)
>> On 08/30/2013 02:33 PM, Mike Turquette wrote:
...
>>> The clock _data_ seems to always have some churn to it. Moving it out to
>>> DT reduces that churn from Linux. My concern above is not about kernel
>>> data size.
>>
>> That sounds like the opposite of what we should be doing.
>>
>> It's fine for kernel code/data to change; that's a natural part of
>> development. Obviously, we should minimize churn, through thorough
>> review, domain knowledge, etc.
>
> And with the "clock mapping" style bindings we'll end up changing both
> the DT binding definition and the kernel. Not great.
What's a "clock mapping" style binding? I guess that means the style
where you have a single DT node that provides multiple clocks, rather
than one DT node per clock?
If the kernel driver changes its internal data, I don't see why that
would have any impact at all on the DT binding definition. We should be
able to use one DT binding definition with arbitrary drivers.
> And I'll respond to your points below but the whole "relocate the
> problem to DT" argument is simply not my main point. What I want to do
> is increase the usefulness of DT by allowing register-level details into
> the binding which can
Can you expand upon why a DT that encodes register-level details is more
useful? I can't see why there would be any difference in usefulness.
next prev parent reply other threads:[~2013-09-04 18:36 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 5:53 [PATCH v4 0/5] clk: dt: bindings for mux, divider & gate clocks Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-22 5:53 ` [PATCH v4 1/5] clk: divider: replace bitfield width with mask Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-22 5:53 ` [PATCH v4 2/5] clk: of: helper for determining number of parent clocks Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-22 5:53 ` [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-28 15:50 ` Kumar Gala
2013-08-28 15:50 ` Kumar Gala
2013-08-29 1:14 ` Mike Turquette
2013-08-29 1:14 ` Mike Turquette
2013-08-29 6:58 ` Tero Kristo
2013-08-29 6:58 ` Tero Kristo
2013-08-30 5:54 ` Tony Lindgren
2013-08-30 5:54 ` Tony Lindgren
2013-08-30 20:02 ` Kumar Gala
2013-08-30 20:02 ` Kumar Gala
2013-08-30 20:33 ` Mike Turquette
2013-08-30 20:33 ` Mike Turquette
2013-08-30 20:48 ` Kumar Gala
2013-08-30 20:48 ` Kumar Gala
2013-08-30 21:37 ` Stephen Warren
2013-08-30 21:37 ` Stephen Warren
2013-09-03 23:22 ` Mike Turquette
2013-09-03 23:22 ` Mike Turquette
2013-09-04 18:36 ` Stephen Warren [this message]
2013-09-04 18:36 ` Stephen Warren
2013-09-05 18:29 ` Mike Turquette
2013-09-05 18:29 ` Mike Turquette
2013-09-05 20:30 ` Stephen Warren
2013-09-05 20:30 ` Stephen Warren
2013-09-05 20:51 ` Sylwester Nawrocki
2013-09-05 20:51 ` Sylwester Nawrocki
2013-09-06 6:53 ` Tero Kristo
2013-09-06 6:53 ` Tero Kristo
2013-09-06 6:53 ` Tero Kristo
2013-09-06 19:01 ` Stephen Warren
2013-09-06 19:01 ` Stephen Warren
2013-09-07 4:15 ` Saravana Kannan
2013-09-07 4:15 ` Saravana Kannan
2013-09-07 12:27 ` Tomasz Figa
2013-09-07 12:27 ` Tomasz Figa
2013-08-22 5:53 ` [PATCH v4 4/5] clk: dt: binding for basic divider clock Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-22 5:53 ` [PATCH v4 5/5] clk: dt: binding for basic gate clock Mike Turquette
2013-08-22 5:53 ` Mike Turquette
2013-08-30 1:45 ` Haojian Zhuang
2013-08-30 1:45 ` Haojian Zhuang
2013-08-30 20:06 ` Stephen Warren
2013-08-30 20:06 ` Stephen Warren
2013-09-04 3:03 ` Haojian Zhuang
2013-09-04 3:03 ` Haojian Zhuang
2013-09-04 17:59 ` Tony Lindgren
2013-09-04 17:59 ` Tony Lindgren
2013-09-07 11:56 ` Tomasz Figa
2013-09-07 11:56 ` Tomasz Figa
2013-08-29 18:23 ` [PATCH v4 0/5] clk: dt: bindings for mux, divider & gate clocks Santosh Shilimkar
2013-08-29 18:23 ` Santosh Shilimkar
2013-08-29 18:23 ` Santosh Shilimkar
2013-08-30 7:05 ` Tero Kristo
2013-08-30 7:05 ` Tero Kristo
2013-08-30 7:05 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52277DBF.7080104@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.