* [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field
@ 2013-09-05 7:02 Duan Jiong
2013-09-05 8:36 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Duan Jiong @ 2013-09-05 7:02 UTC (permalink / raw)
To: dwmw2; +Cc: linux-kernel
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 18e7761..9b8aaf3 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -87,7 +87,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;
err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field
2013-09-05 7:02 [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field Duan Jiong
@ 2013-09-05 8:36 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2013-09-05 8:36 UTC (permalink / raw)
To: Duan Jiong; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Thu, 2013-09-05 at 15:02 +0800, Duan Jiong wrote:
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }
Thanks, but this is already fixed in linux-next, and will be going to
Linus very shortly:
http://git.infradead.org/linux-mtd.git/commitdiff/d2b1bd1422
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-05 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 7:02 [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field Duan Jiong
2013-09-05 8:36 ` David Woodhouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.