From: Jens Axboe <axboe@kernel.dk>
To: dave@jikos.cz
Cc: fio@vger.kernel.org
Subject: Re: fio --showcmd fails if directory= does not exist
Date: Fri, 06 Sep 2013 10:00:57 -0600 [thread overview]
Message-ID: <5229FC39.50905@kernel.dk> (raw)
In-Reply-To: <20130906123812.GB9122@twin.jikos.cz>
On 09/06/2013 06:38 AM, David Sterba wrote:
> Hi,
>
> I'm using "fio --showcmd file.job" to convert a script to plain
> commandline arguments and this fails if the directory specified in job
> file does not exist. While this has to be an error if the job is being
> executed, it should not be in context of --showcmd.
>
> To reproduce:
> $ cat job.fio
> [global]
> directory=/x
>
> $ fio --showcmd job.fio
> fio: /x is not a directory
> fio: failed parsing directory=/x
> fio: job global dropped
>
> Expected output:
> fio --directory=/x
That's definitely a bug, the callbacks should not verify anything if we
are only in dump or parse only mode. I've committed a fix.
--
Jens Axboe
next prev parent reply other threads:[~2013-09-06 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 12:38 fio --showcmd fails if directory= does not exist David Sterba
2013-09-06 16:00 ` Jens Axboe [this message]
2013-09-09 13:06 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229FC39.50905@kernel.dk \
--to=axboe@kernel.dk \
--cc=dave@jikos.cz \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.