* fio --showcmd fails if directory= does not exist
@ 2013-09-06 12:38 David Sterba
2013-09-06 16:00 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2013-09-06 12:38 UTC (permalink / raw)
To: fio
Hi,
I'm using "fio --showcmd file.job" to convert a script to plain
commandline arguments and this fails if the directory specified in job
file does not exist. While this has to be an error if the job is being
executed, it should not be in context of --showcmd.
To reproduce:
$ cat job.fio
[global]
directory=/x
$ fio --showcmd job.fio
fio: /x is not a directory
fio: failed parsing directory=/x
fio: job global dropped
Expected output:
fio --directory=/x
david
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fio --showcmd fails if directory= does not exist
2013-09-06 12:38 fio --showcmd fails if directory= does not exist David Sterba
@ 2013-09-06 16:00 ` Jens Axboe
2013-09-09 13:06 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2013-09-06 16:00 UTC (permalink / raw)
To: dave; +Cc: fio
On 09/06/2013 06:38 AM, David Sterba wrote:
> Hi,
>
> I'm using "fio --showcmd file.job" to convert a script to plain
> commandline arguments and this fails if the directory specified in job
> file does not exist. While this has to be an error if the job is being
> executed, it should not be in context of --showcmd.
>
> To reproduce:
> $ cat job.fio
> [global]
> directory=/x
>
> $ fio --showcmd job.fio
> fio: /x is not a directory
> fio: failed parsing directory=/x
> fio: job global dropped
>
> Expected output:
> fio --directory=/x
That's definitely a bug, the callbacks should not verify anything if we
are only in dump or parse only mode. I've committed a fix.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fio --showcmd fails if directory= does not exist
2013-09-06 16:00 ` Jens Axboe
@ 2013-09-09 13:06 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2013-09-09 13:06 UTC (permalink / raw)
To: Jens Axboe; +Cc: dave, fio
On Fri, Sep 06, 2013 at 10:00:57AM -0600, Jens Axboe wrote:
> That's definitely a bug, the callbacks should not verify anything if we
> are only in dump or parse only mode. I've committed a fix.
Thanks, I've verified that all my .fio scripts are converted fine.
david
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-09 13:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-06 12:38 fio --showcmd fails if directory= does not exist David Sterba
2013-09-06 16:00 ` Jens Axboe
2013-09-09 13:06 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.