diff for duplicates of <522B8A45.4030005@redhat.com> diff --git a/a/1.txt b/N1/1.txt index aea5bbd..54cf35a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,11 +2,11 @@ On 09/07/2013 09:40 PM, Michio Honda wrote: > Hi, > > Sorry for that I didn't respond to that warning. -> You are right, laddr = NULL && addrcnt = 1 is the indicator of the function called by +> You are right, laddr == NULL && addrcnt == 1 is the indicator of the function called by > asconf_mgmt(). > > Since your patch is actually redundant, I would suggest putting comment on the -> line of "if ((laddr = NULL) && (addrcnt = 1)) {", and/or on the checking in your patch. +> line of "if ((laddr == NULL) && (addrcnt == 1)) {", and/or on the checking in your patch. I think as is is just fine. One can read through the Git log and then see the rationale behind a change (which is in most cases even more worth than diff --git a/a/content_digest b/N1/content_digest index 8c6f8e6..f9c4e88 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0B8C81C0E-1D13-40A9-A39F-4E5C8069366D@sfc.wide.ad.jp\0" "From\0Daniel Borkmann <dborkman@redhat.com>\0" "Subject\0Re: [PATCH net] net: sctp: fix smatch warning in sctp_send_asconf_del_ip\0" - "Date\0Sat, 07 Sep 2013 20:19:17 +0000\0" + "Date\0Sat, 07 Sep 2013 22:19:17 +0200\0" "To\0Michio Honda <micchie@sfc.wide.ad.jp>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -14,15 +14,15 @@ "> Hi,\n" ">\n" "> Sorry for that I didn't respond to that warning.\n" - "> You are right, laddr = NULL && addrcnt = 1 is the indicator of the function called by\n" + "> You are right, laddr == NULL && addrcnt == 1 is the indicator of the function called by\n" "> asconf_mgmt().\n" ">\n" "> Since your patch is actually redundant, I would suggest putting comment on the\n" - "> line of \"if ((laddr = NULL) && (addrcnt = 1)) {\", and/or on the checking in your patch.\n" + "> line of \"if ((laddr == NULL) && (addrcnt == 1)) {\", and/or on the checking in your patch.\n" "\n" "I think as is is just fine. One can read through the Git log and then see\n" "the rationale behind a change (which is in most cases even more worth than\n" "a comment). If this function should ever be called from somewhere else for\n" whatever reason, then this comment would already be obsolete. -1016b09b3d9b8fed110371c615c1c377ec96dd84ccdb4c7e6115862fc9eb6a94 +f1c766df0431641dba5e84623cb893085a569918516c45552a99abc43e15f5c7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.