From: Daniel Borkmann <dborkman@redhat.com>
To: Michio Honda <micchie@sfc.wide.ad.jp>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] net: sctp: fix smatch warning in sctp_send_asconf_del_ip
Date: Sat, 07 Sep 2013 20:19:17 +0000 [thread overview]
Message-ID: <522B8A45.4030005@redhat.com> (raw)
In-Reply-To: <B8C81C0E-1D13-40A9-A39F-4E5C8069366D@sfc.wide.ad.jp>
On 09/07/2013 09:40 PM, Michio Honda wrote:
> Hi,
>
> Sorry for that I didn't respond to that warning.
> You are right, laddr = NULL && addrcnt = 1 is the indicator of the function called by
> asconf_mgmt().
>
> Since your patch is actually redundant, I would suggest putting comment on the
> line of "if ((laddr = NULL) && (addrcnt = 1)) {", and/or on the checking in your patch.
I think as is is just fine. One can read through the Git log and then see
the rationale behind a change (which is in most cases even more worth than
a comment). If this function should ever be called from somewhere else for
whatever reason, then this comment would already be obsolete.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Michio Honda <micchie@sfc.wide.ad.jp>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] net: sctp: fix smatch warning in sctp_send_asconf_del_ip
Date: Sat, 07 Sep 2013 22:19:17 +0200 [thread overview]
Message-ID: <522B8A45.4030005@redhat.com> (raw)
In-Reply-To: <B8C81C0E-1D13-40A9-A39F-4E5C8069366D@sfc.wide.ad.jp>
On 09/07/2013 09:40 PM, Michio Honda wrote:
> Hi,
>
> Sorry for that I didn't respond to that warning.
> You are right, laddr == NULL && addrcnt == 1 is the indicator of the function called by
> asconf_mgmt().
>
> Since your patch is actually redundant, I would suggest putting comment on the
> line of "if ((laddr == NULL) && (addrcnt == 1)) {", and/or on the checking in your patch.
I think as is is just fine. One can read through the Git log and then see
the rationale behind a change (which is in most cases even more worth than
a comment). If this function should ever be called from somewhere else for
whatever reason, then this comment would already be obsolete.
next prev parent reply other threads:[~2013-09-07 20:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-07 18:51 [PATCH net] net: sctp: fix smatch warning in sctp_send_asconf_del_ip Daniel Borkmann
2013-09-07 18:51 ` Daniel Borkmann
2013-09-07 19:40 ` Michio Honda
2013-09-07 19:40 ` Michio Honda
2013-09-07 20:11 ` Neil Horman
2013-09-07 20:11 ` Neil Horman
2013-09-07 20:19 ` Michio Honda
2013-09-07 20:19 ` Michio Honda
2013-09-07 20:19 ` Daniel Borkmann [this message]
2013-09-07 20:19 ` Daniel Borkmann
2013-09-07 20:21 ` Michio Honda
2013-09-07 20:21 ` Michio Honda
2013-09-07 20:12 ` Neil Horman
2013-09-07 20:12 ` Neil Horman
2013-09-10 14:18 ` Vlad Yasevich
2013-09-10 14:18 ` Vlad Yasevich
2013-09-11 20:14 ` David Miller
2013-09-11 20:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522B8A45.4030005@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=micchie@sfc.wide.ad.jp \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.