From: Martin Peres <martin.peres-BktLLJ5BOkI@public.gmane.org>
To: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/nouveau/therm: ack any pending IRQ at init v2
Date: Mon, 09 Sep 2013 00:44:48 +0200 [thread overview]
Message-ID: <522CFDE0.7000009@labri.fr> (raw)
In-Reply-To: <CACAvsv6+9TqeTjMeMPdAwDrxLbbZ1sBJDQFmE7Xum9ryebns7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 04/09/2013 03:52, Ben Skeggs wrote:
> On Sat, Aug 31, 2013 at 10:06 AM, Martin Peres <martin.peres-GANU6spQydw@public.gmane.org> wrote:
>> From: Martin Peres <martin.peres-BktLLJ5BOkI@public.gmane.org>
>>
>> This is safe because ptherm hasn't been configured yet and will be a
>> little further down the initialization path. Ptherm should be safe
>> regarding to runtime reconfiguration.
> Any objections to instead sticking the ACK in a single fini() hook
> (along with additional code to disable all therm interrupts), and
> having the IRQ handle silently ignore any non-requested IRQs (see what
> the copy engine irq handler does, for example)?
>
> Ben.
Hi Ben,
Sorry for the late answer. This all perfectly make sense. Please have a
look at the patches I've just sent.
next prev parent reply other threads:[~2013-09-08 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 23:58 [PATCH 1/2] drm/nouveau/bios/therm: handle vbioses with duplicate entries (mostly nva5) Martin Peres
[not found] ` <1377907131-15099-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2013-08-30 23:58 ` [PATCH 2/2] drm/nv84/therm: ack any pending IRQ at init Martin Peres
[not found] ` <1377907131-15099-2-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2013-08-31 0:06 ` [PATCH] drm/nouveau/therm: ack any pending IRQ at init v2 Martin Peres
[not found] ` <1377907571-15301-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2013-09-04 1:52 ` Ben Skeggs
[not found] ` <CACAvsv6+9TqeTjMeMPdAwDrxLbbZ1sBJDQFmE7Xum9ryebns7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-08 22:44 ` Martin Peres [this message]
2013-08-31 0:08 ` [PATCH 1/2] drm/nouveau/bios/therm: handle vbioses with duplicate entries (mostly nva5) Martin Peres
2013-09-04 1:55 ` Ben Skeggs
[not found] ` <CACAvsv5VTQvVcQhB0_=GY4Jjx=3-EAd+QMqzemR7qsDeh7KxzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-08 22:46 ` Martin Peres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522CFDE0.7000009@labri.fr \
--to=martin.peres-bktllj5boki@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.