Re: [PATCH 1/2] drm/nouveau/bios/therm: handle vbioses with duplicate entries (mostly nva5)

[Martin Peres <martin.peres-BktLLJ5BOkI@public.gmane.org>]

On 04/09/2013 03:55, Ben Skeggs wrote:
> On Sat, Aug 31, 2013 at 9:58 AM, Martin Peres <martin.peres-GANU6spQydw@public.gmane.org> wrote:
>> From: Martin Peres <martin.peres-BktLLJ5BOkI@public.gmane.org>
>>
>> Some vbioses have extra useless entries after "the end" of the table. This is
>> problematic since all of the vbios I found with this issue redefine the
>> pwm freq divider to insane levels (52750 Hz instead of 2500), thus breaking
>> fan management.
>>
>> The first solution to solve this mess would be to change the length of the
>> table. The solution I choose was simply to avoid setting the pwm freq twice
>> as the other redefinitions are harmless with our current parser.
> I'm still *really* not convinced we're using the thermal table correctly....
>
> However, this makes sense for our current handling, so, merged.
>
> Thanks,
> Ben.

Well, I do agree that the first versions of the vbios table really felt 
like a script but this isn't the case anymore (not sure how I tested 
this though as it was more than a year ago).