* [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-09 6:10 ` Beomho Seo
0 siblings, 0 replies; 6+ messages in thread
From: Beomho Seo @ 2013-09-09 6:10 UTC (permalink / raw)
To: linux-iio
Cc: devicetree, jic23, rob.herring, pawel.moll, mark.rutland, warren,
ian.campbell, Sylwester Nawrocki, Jacek Anaszewski, Jaehoon Chung,
Beomho Seo
This patch add device tree binding documentation for CM36651
proximity/light sensor.
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
.../devicetree/bindings/iio/light/cm36651.txt | 24
++++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.txt | 1 +
2 files changed, 25 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
b/Documentation/devicetree/bindings/iio/light/cm36651.txt
new file mode 100644
index 0000000..3a6ba38
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
@@ -0,0 +1,24 @@
+* Capella CM36651 I2C Proximity and Color Light sensor
+
+Required properties:
+- compatible: must be "capella,cm36651"
+- reg: the I2C address of the device
+- interrupts: interrupt to which the chip is connected
+- vled-supply: regulator for the sensor device, as covered
+ in ../../regulator/regulator.txt
+
+Example:
+
+ i2c_cm36651: i2c-gpio {
+ /* ... */
+
+ cm36651@18 {
+ compatible = "capella,cm36651";
+ reg = <0x18>;
+ interrupt-parent = <&gpx0>;
+ interrupts = <2 0>;
+ vled-supply = <&ps_als_reg>;
+ };
+
+ /* ... */
+ };
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index ec4d713..044796d 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ brcm Broadcom Corporation
cavium Cavium, Inc.
chrp Common Hardware Reference Platform
cirrus Cirrus Logic, Inc.
+capella Capella Microsystems, Inc
cortina Cortina Systems, Inc.
dallas Maxim Integrated Products (formerly Dallas Semiconductor)
davicom DAVICOM Semiconductor, Inc.
--
1.7.9.5
--
Beomho Seo, Assistant Engineer
System S/W Lab., S/W Platform Team, Software Center
Samsung Electronics
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-09 6:10 ` Beomho Seo
0 siblings, 0 replies; 6+ messages in thread
From: Beomho Seo @ 2013-09-09 6:10 UTC (permalink / raw)
To: linux-iio-u79uwXL29TY76Z2rM5mHXA
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, jic23-KWPb1pKIrIJaa/9Udqfwiw,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, warren-3lzwWm7+Weoh9ZMKESR00Q,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA, Sylwester Nawrocki,
Jacek Anaszewski, Jaehoon Chung, Beomho Seo
This patch add device tree binding documentation for CM36651
proximity/light sensor.
Signed-off-by: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
.../devicetree/bindings/iio/light/cm36651.txt | 24
++++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.txt | 1 +
2 files changed, 25 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
b/Documentation/devicetree/bindings/iio/light/cm36651.txt
new file mode 100644
index 0000000..3a6ba38
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
@@ -0,0 +1,24 @@
+* Capella CM36651 I2C Proximity and Color Light sensor
+
+Required properties:
+- compatible: must be "capella,cm36651"
+- reg: the I2C address of the device
+- interrupts: interrupt to which the chip is connected
+- vled-supply: regulator for the sensor device, as covered
+ in ../../regulator/regulator.txt
+
+Example:
+
+ i2c_cm36651: i2c-gpio {
+ /* ... */
+
+ cm36651@18 {
+ compatible = "capella,cm36651";
+ reg = <0x18>;
+ interrupt-parent = <&gpx0>;
+ interrupts = <2 0>;
+ vled-supply = <&ps_als_reg>;
+ };
+
+ /* ... */
+ };
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index ec4d713..044796d 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ brcm Broadcom Corporation
cavium Cavium, Inc.
chrp Common Hardware Reference Platform
cirrus Cirrus Logic, Inc.
+capella Capella Microsystems, Inc
cortina Cortina Systems, Inc.
dallas Maxim Integrated Products (formerly Dallas Semiconductor)
davicom DAVICOM Semiconductor, Inc.
--
1.7.9.5
--
Beomho Seo, Assistant Engineer
System S/W Lab., S/W Platform Team, Software Center
Samsung Electronics
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-20 9:40 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2013-09-20 9:40 UTC (permalink / raw)
To: Beomho Seo
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
jic23@cam.ac.uk, rob.herring@calxeda.com, Pawel Moll,
warren@wwwdotorg.org, ian.campbell@citrix.com, Sylwester Nawrocki,
Jacek Anaszewski, Jaehoon Chung
On Mon, Sep 09, 2013 at 07:10:41AM +0100, Beomho Seo wrote:
> This patch add device tree binding documentation for CM36651
> proximity/light sensor.
>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
> .../devicetree/bindings/iio/light/cm36651.txt | 24
> ++++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 2 files changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
> b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> new file mode 100644
> index 0000000..3a6ba38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> @@ -0,0 +1,24 @@
> +* Capella CM36651 I2C Proximity and Color Light sensor
> +
> +Required properties:
> +- compatible: must be "capella,cm36651"
> +- reg: the I2C address of the device
> +- interrupts: interrupt to which the chip is connected
Nit: I'd prefer something like the below:
- interrupts: interrupt-specifier for the sole interrupt generated by
the device.
> +- vled-supply: regulator for the sensor device, as covered
> + in ../../regulator/regulator.txt
I assume by the name that this is the regulator for the LED that's used
alongside the sensor, rather than for the sensor itself?
Is the LED part of the CM36651 unit, or is it external? I couldn't find
any documentation for the unit.
> +
> +Example:
> +
> + i2c_cm36651: i2c-gpio {
> + /* ... */
> +
> + cm36651@18 {
> + compatible = "capella,cm36651";
> + reg = <0x18>;
> + interrupt-parent = <&gpx0>;
> + interrupts = <2 0>;
> + vled-supply = <&ps_als_reg>;
> + };
> +
> + /* ... */
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index ec4d713..044796d 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ brcm Broadcom Corporation
> cavium Cavium, Inc.
> chrp Common Hardware Reference Platform
> cirrus Cirrus Logic, Inc.
> +capella Capella Microsystems, Inc
The vendor prefix looks OK to me. However, it should apper before cavium
to maintain the ordering of the file.
Thanks,
Mark.
> cortina Cortina Systems, Inc.
> dallas Maxim Integrated Products (formerly Dallas Semiconductor)
> davicom DAVICOM Semiconductor, Inc.
> --
> 1.7.9.5
>
> --
> Beomho Seo, Assistant Engineer
> System S/W Lab., S/W Platform Team, Software Center
> Samsung Electronics
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-20 9:40 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2013-09-20 9:40 UTC (permalink / raw)
To: Beomho Seo
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, Pawel Moll,
warren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
Sylwester Nawrocki, Jacek Anaszewski, Jaehoon Chung
On Mon, Sep 09, 2013 at 07:10:41AM +0100, Beomho Seo wrote:
> This patch add device tree binding documentation for CM36651
> proximity/light sensor.
>
> Signed-off-by: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> .../devicetree/bindings/iio/light/cm36651.txt | 24
> ++++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 2 files changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
> b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> new file mode 100644
> index 0000000..3a6ba38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> @@ -0,0 +1,24 @@
> +* Capella CM36651 I2C Proximity and Color Light sensor
> +
> +Required properties:
> +- compatible: must be "capella,cm36651"
> +- reg: the I2C address of the device
> +- interrupts: interrupt to which the chip is connected
Nit: I'd prefer something like the below:
- interrupts: interrupt-specifier for the sole interrupt generated by
the device.
> +- vled-supply: regulator for the sensor device, as covered
> + in ../../regulator/regulator.txt
I assume by the name that this is the regulator for the LED that's used
alongside the sensor, rather than for the sensor itself?
Is the LED part of the CM36651 unit, or is it external? I couldn't find
any documentation for the unit.
> +
> +Example:
> +
> + i2c_cm36651: i2c-gpio {
> + /* ... */
> +
> + cm36651@18 {
> + compatible = "capella,cm36651";
> + reg = <0x18>;
> + interrupt-parent = <&gpx0>;
> + interrupts = <2 0>;
> + vled-supply = <&ps_als_reg>;
> + };
> +
> + /* ... */
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index ec4d713..044796d 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ brcm Broadcom Corporation
> cavium Cavium, Inc.
> chrp Common Hardware Reference Platform
> cirrus Cirrus Logic, Inc.
> +capella Capella Microsystems, Inc
The vendor prefix looks OK to me. However, it should apper before cavium
to maintain the ordering of the file.
Thanks,
Mark.
> cortina Cortina Systems, Inc.
> dallas Maxim Integrated Products (formerly Dallas Semiconductor)
> davicom DAVICOM Semiconductor, Inc.
> --
> 1.7.9.5
>
> --
> Beomho Seo, Assistant Engineer
> System S/W Lab., S/W Platform Team, Software Center
> Samsung Electronics
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-26 2:35 ` Beomho Seo
0 siblings, 0 replies; 6+ messages in thread
From: Beomho Seo @ 2013-09-26 2:35 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
jic23@cam.ac.uk, rob.herring@calxeda.com, Pawel Moll,
warren@wwwdotorg.org, ian.campbell@citrix.com, Sylwester Nawrocki,
Jacek Anaszewski, Jaehoon Chung
Thank you for review.
I revised on your advice.
I will send v3 patch in the course of today.
reply about your question inline
> On Mon, Sep 09, 2013 at 07:10:41AM +0100, Beomho Seo wrote:
>> This patch add device tree binding documentation for CM36651
>> proximity/light sensor.
>>
>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>> ---
>> .../devicetree/bindings/iio/light/cm36651.txt | 24
>> ++++++++++++++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> 2 files changed, 25 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> b/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> new file mode 100644
>> index 0000000..3a6ba38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> @@ -0,0 +1,24 @@
>> +* Capella CM36651 I2C Proximity and Color Light sensor
>> +
>> +Required properties:
>> +- compatible: must be "capella,cm36651"
>> +- reg: the I2C address of the device
>> +- interrupts: interrupt to which the chip is connected
>
> Nit: I'd prefer something like the below:
>
> - interrupts: interrupt-specifier for the sole interrupt generated by
> the device.
>
>> +- vled-supply: regulator for the sensor device, as covered
>> + in ../../regulator/regulator.txt
>
> I assume by the name that this is the regulator for the LED that's used
> alongside the sensor, rather than for the sensor itself?
>
> Is the LED part of the CM36651 unit, or is it external? I couldn't find
> any documentation for the unit.
>
vled_suppy is the regulator for the IR LED. In order to cm36651 manual, IR_LED part of the cm36651 unit.
>> +
>> +Example:
>> +
>> + i2c_cm36651: i2c-gpio {
>> + /* ... */
>> +
>> + cm36651@18 {
>> + compatible = "capella,cm36651";
>> + reg = <0x18>;
>> + interrupt-parent = <&gpx0>;
>> + interrupts = <2 0>;
>> + vled-supply = <&ps_als_reg>;
>> + };
>> +
>> + /* ... */
>> + };
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index ec4d713..044796d 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -17,6 +17,7 @@ brcm Broadcom Corporation
>> cavium Cavium, Inc.
>> chrp Common Hardware Reference Platform
>> cirrus Cirrus Logic, Inc.
>> +capella Capella Microsystems, Inc
>
> The vendor prefix looks OK to me. However, it should apper before cavium
> to maintain the ordering of the file.
>
> Thanks,
> Mark.
>
>> cortina Cortina Systems, Inc.
>> dallas Maxim Integrated Products (formerly Dallas Semiconductor)
>> davicom DAVICOM Semiconductor, Inc.
>> --
>> 1.7.9.5
>>
>> --
>> Beomho Seo, Assistant Engineer
>> System S/W Lab., S/W Platform Team, Software Center
>> Samsung Electronics
>>
>
--
Best Regards,
Beomho Seo, Assistant Engineer
System S/W Lab., S/W Platform Team, Software Center
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor
@ 2013-09-26 2:35 ` Beomho Seo
0 siblings, 0 replies; 6+ messages in thread
From: Beomho Seo @ 2013-09-26 2:35 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, Pawel Moll,
warren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
Sylwester Nawrocki, Jacek Anaszewski, Jaehoon Chung
Thank you for review.
I revised on your advice.
I will send v3 patch in the course of today.
reply about your question inline
> On Mon, Sep 09, 2013 at 07:10:41AM +0100, Beomho Seo wrote:
>> This patch add device tree binding documentation for CM36651
>> proximity/light sensor.
>>
>> Signed-off-by: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> ---
>> .../devicetree/bindings/iio/light/cm36651.txt | 24
>> ++++++++++++++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> 2 files changed, 25 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> b/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> new file mode 100644
>> index 0000000..3a6ba38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
>> @@ -0,0 +1,24 @@
>> +* Capella CM36651 I2C Proximity and Color Light sensor
>> +
>> +Required properties:
>> +- compatible: must be "capella,cm36651"
>> +- reg: the I2C address of the device
>> +- interrupts: interrupt to which the chip is connected
>
> Nit: I'd prefer something like the below:
>
> - interrupts: interrupt-specifier for the sole interrupt generated by
> the device.
>
>> +- vled-supply: regulator for the sensor device, as covered
>> + in ../../regulator/regulator.txt
>
> I assume by the name that this is the regulator for the LED that's used
> alongside the sensor, rather than for the sensor itself?
>
> Is the LED part of the CM36651 unit, or is it external? I couldn't find
> any documentation for the unit.
>
vled_suppy is the regulator for the IR LED. In order to cm36651 manual, IR_LED part of the cm36651 unit.
>> +
>> +Example:
>> +
>> + i2c_cm36651: i2c-gpio {
>> + /* ... */
>> +
>> + cm36651@18 {
>> + compatible = "capella,cm36651";
>> + reg = <0x18>;
>> + interrupt-parent = <&gpx0>;
>> + interrupts = <2 0>;
>> + vled-supply = <&ps_als_reg>;
>> + };
>> +
>> + /* ... */
>> + };
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index ec4d713..044796d 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -17,6 +17,7 @@ brcm Broadcom Corporation
>> cavium Cavium, Inc.
>> chrp Common Hardware Reference Platform
>> cirrus Cirrus Logic, Inc.
>> +capella Capella Microsystems, Inc
>
> The vendor prefix looks OK to me. However, it should apper before cavium
> to maintain the ordering of the file.
>
> Thanks,
> Mark.
>
>> cortina Cortina Systems, Inc.
>> dallas Maxim Integrated Products (formerly Dallas Semiconductor)
>> davicom DAVICOM Semiconductor, Inc.
>> --
>> 1.7.9.5
>>
>> --
>> Beomho Seo, Assistant Engineer
>> System S/W Lab., S/W Platform Team, Software Center
>> Samsung Electronics
>>
>
--
Best Regards,
Beomho Seo, Assistant Engineer
System S/W Lab., S/W Platform Team, Software Center
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-26 2:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 6:10 [PATCH 2/2] DT: Add binding documentation for CM36651 proximity/light sensor Beomho Seo
2013-09-09 6:10 ` Beomho Seo
2013-09-20 9:40 ` Mark Rutland
2013-09-20 9:40 ` Mark Rutland
2013-09-26 2:35 ` Beomho Seo
2013-09-26 2:35 ` Beomho Seo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.