* [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer
@ 2013-09-09 5:29 Jingoo Han
2013-09-09 6:53 ` Jean Delvare
2013-09-09 10:40 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-09 5:29 UTC (permalink / raw)
To: lm-sensors
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/hwmon/ina2xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index 18c0623..70a39a8 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -233,8 +233,7 @@ static int ina2xx_probe(struct i2c_client *client,
return -ENOMEM;
if (dev_get_platdata(&client->dev)) {
- pdata - (struct ina2xx_platform_data *)dev_get_platdata(&client->dev);
+ pdata = dev_get_platdata(&client->dev);
shunt = pdata->shunt_uohms;
} else if (!of_property_read_u32(client->dev.of_node,
"shunt-resistor", &val)) {
--
1.7.10.4
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer
2013-09-09 5:29 [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer Jingoo Han
@ 2013-09-09 6:53 ` Jean Delvare
2013-09-09 10:40 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2013-09-09 6:53 UTC (permalink / raw)
To: lm-sensors
On Mon, 09 Sep 2013 14:29:32 +0900, Jingoo Han wrote:
> Casting the return value which is a void pointer is redundant.
> The conversion from void pointer to any other pointer type is
> guaranteed by the C programming language.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/hwmon/ina2xx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index 18c0623..70a39a8 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -233,8 +233,7 @@ static int ina2xx_probe(struct i2c_client *client,
> return -ENOMEM;
>
> if (dev_get_platdata(&client->dev)) {
> - pdata > - (struct ina2xx_platform_data *)dev_get_platdata(&client->dev);
> + pdata = dev_get_platdata(&client->dev);
> shunt = pdata->shunt_uohms;
> } else if (!of_property_read_u32(client->dev.of_node,
> "shunt-resistor", &val)) {
Acked-by: Jean Delvare <khali@linux-fr.org>
Guenter, I'll let you pick it.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer
2013-09-09 5:29 [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer Jingoo Han
2013-09-09 6:53 ` Jean Delvare
@ 2013-09-09 10:40 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-09-09 10:40 UTC (permalink / raw)
To: lm-sensors
On 09/08/2013 11:53 PM, Jean Delvare wrote:
> On Mon, 09 Sep 2013 14:29:32 +0900, Jingoo Han wrote:
>> Casting the return value which is a void pointer is redundant.
>> The conversion from void pointer to any other pointer type is
>> guaranteed by the C programming language.
>>
>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>> ---
>> drivers/hwmon/ina2xx.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
>> index 18c0623..70a39a8 100644
>> --- a/drivers/hwmon/ina2xx.c
>> +++ b/drivers/hwmon/ina2xx.c
>> @@ -233,8 +233,7 @@ static int ina2xx_probe(struct i2c_client *client,
>> return -ENOMEM;
>>
>> if (dev_get_platdata(&client->dev)) {
>> - pdata >> - (struct ina2xx_platform_data *)dev_get_platdata(&client->dev);
>> + pdata = dev_get_platdata(&client->dev);
>> shunt = pdata->shunt_uohms;
>> } else if (!of_property_read_u32(client->dev.of_node,
>> "shunt-resistor", &val)) {
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> Guenter, I'll let you pick it.
>
Applied, thanks
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-09 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 5:29 [lm-sensors] [PATCH] hwmon: (ina2xx) Remove casting the return value which is a void pointer Jingoo Han
2013-09-09 6:53 ` Jean Delvare
2013-09-09 10:40 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.