* [PATCH] mmc: atmel-mci: abort transfer on timeout error
@ 2013-09-09 15:29 ` ludovic.desroches at atmel.com
0 siblings, 0 replies; 6+ messages in thread
From: ludovic.desroches @ 2013-09-09 15:29 UTC (permalink / raw)
To: linux-arm-kernel, linux-mmc
Cc: cjb, nicolas.ferre, etesial, Ludovic Desroches
From: Ludovic Desroches <ludovic.desroches@atmel.com>
When a software timeout occurs, the transfer is not stopped. In DMA case, it
causes DMA channel to be stuck because the transfer is still active causing
following transfers to be queued but not computed.
Cc: <stable@vger.kernel.org> #3.9+
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Reported-by: Alexander Morozov <etesial@gmail.com>
---
drivers/mmc/host/atmel-mci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index bdb84da..e9ea2fc 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -582,6 +582,13 @@ static void atmci_timeout_timer(unsigned long data)
if (host->mrq->cmd->data) {
host->mrq->cmd->data->error = -ETIMEDOUT;
host->data = NULL;
+ /*
+ * With some SDIO modules, sometimes DMA transfer hangs. If
+ * stop_transfer() is not called then the DMA request is not
+ * removed, following ones are queued and never computed.
+ */
+ if (host->state == STATE_DATA_XFER)
+ host->stop_transfer(host);
} else {
host->mrq->cmd->error = -ETIMEDOUT;
host->cmd = NULL;
--
1.7.11.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mmc: atmel-mci: abort transfer on timeout error
@ 2013-09-09 15:29 ` ludovic.desroches at atmel.com
0 siblings, 0 replies; 6+ messages in thread
From: ludovic.desroches at atmel.com @ 2013-09-09 15:29 UTC (permalink / raw)
To: linux-arm-kernel
From: Ludovic Desroches <ludovic.desroches@atmel.com>
When a software timeout occurs, the transfer is not stopped. In DMA case, it
causes DMA channel to be stuck because the transfer is still active causing
following transfers to be queued but not computed.
Cc: <stable@vger.kernel.org> #3.9+
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Reported-by: Alexander Morozov <etesial@gmail.com>
---
drivers/mmc/host/atmel-mci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index bdb84da..e9ea2fc 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -582,6 +582,13 @@ static void atmci_timeout_timer(unsigned long data)
if (host->mrq->cmd->data) {
host->mrq->cmd->data->error = -ETIMEDOUT;
host->data = NULL;
+ /*
+ * With some SDIO modules, sometimes DMA transfer hangs. If
+ * stop_transfer() is not called then the DMA request is not
+ * removed, following ones are queued and never computed.
+ */
+ if (host->state == STATE_DATA_XFER)
+ host->stop_transfer(host);
} else {
host->mrq->cmd->error = -ETIMEDOUT;
host->cmd = NULL;
--
1.7.11.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: abort transfer on timeout error
2013-09-09 15:29 ` ludovic.desroches at atmel.com
@ 2013-09-10 7:54 ` Nicolas Ferre
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2013-09-10 7:54 UTC (permalink / raw)
To: ludovic.desroches, linux-mmc, cjb; +Cc: linux-arm-kernel, etesial
On 09/09/2013 17:29, ludovic.desroches@atmel.com :
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> When a software timeout occurs, the transfer is not stopped. In DMA case, it
> causes DMA channel to be stuck because the transfer is still active causing
> following transfers to be queued but not computed.
>
> Cc: <stable@vger.kernel.org> #3.9+
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> Reported-by: Alexander Morozov <etesial@gmail.com>
> ---
> drivers/mmc/host/atmel-mci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index bdb84da..e9ea2fc 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -582,6 +582,13 @@ static void atmci_timeout_timer(unsigned long data)
> if (host->mrq->cmd->data) {
> host->mrq->cmd->data->error = -ETIMEDOUT;
> host->data = NULL;
> + /*
> + * With some SDIO modules, sometimes DMA transfer hangs. If
> + * stop_transfer() is not called then the DMA request is not
> + * removed, following ones are queued and never computed.
> + */
> + if (host->state == STATE_DATA_XFER)
> + host->stop_transfer(host);
> } else {
> host->mrq->cmd->error = -ETIMEDOUT;
> host->cmd = NULL;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: atmel-mci: abort transfer on timeout error
@ 2013-09-10 7:54 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2013-09-10 7:54 UTC (permalink / raw)
To: linux-arm-kernel
On 09/09/2013 17:29, ludovic.desroches at atmel.com :
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> When a software timeout occurs, the transfer is not stopped. In DMA case, it
> causes DMA channel to be stuck because the transfer is still active causing
> following transfers to be queued but not computed.
>
> Cc: <stable@vger.kernel.org> #3.9+
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> Reported-by: Alexander Morozov <etesial@gmail.com>
> ---
> drivers/mmc/host/atmel-mci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index bdb84da..e9ea2fc 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -582,6 +582,13 @@ static void atmci_timeout_timer(unsigned long data)
> if (host->mrq->cmd->data) {
> host->mrq->cmd->data->error = -ETIMEDOUT;
> host->data = NULL;
> + /*
> + * With some SDIO modules, sometimes DMA transfer hangs. If
> + * stop_transfer() is not called then the DMA request is not
> + * removed, following ones are queued and never computed.
> + */
> + if (host->state == STATE_DATA_XFER)
> + host->stop_transfer(host);
> } else {
> host->mrq->cmd->error = -ETIMEDOUT;
> host->cmd = NULL;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: atmel-mci: abort transfer on timeout error
2013-09-10 7:54 ` Nicolas Ferre
@ 2013-09-26 1:46 ` Chris Ball
-1 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2013-09-26 1:46 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: ludovic.desroches, linux-mmc, linux-arm-kernel, etesial
Hi,
On Tue, Sep 10 2013, Nicolas Ferre wrote:
> On 09/09/2013 17:29, ludovic.desroches@atmel.com :
>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>
>> When a software timeout occurs, the transfer is not stopped. In DMA case, it
>> causes DMA channel to be stuck because the transfer is still active causing
>> following transfers to be queued but not computed.
>>
>> Cc: <stable@vger.kernel.org> #3.9+
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>> Reported-by: Alexander Morozov <etesial@gmail.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: atmel-mci: abort transfer on timeout error
@ 2013-09-26 1:46 ` Chris Ball
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2013-09-26 1:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Sep 10 2013, Nicolas Ferre wrote:
> On 09/09/2013 17:29, ludovic.desroches at atmel.com :
>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>
>> When a software timeout occurs, the transfer is not stopped. In DMA case, it
>> causes DMA channel to be stuck because the transfer is still active causing
>> following transfers to be queued but not computed.
>>
>> Cc: <stable@vger.kernel.org> #3.9+
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>> Reported-by: Alexander Morozov <etesial@gmail.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-26 1:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 15:29 [PATCH] mmc: atmel-mci: abort transfer on timeout error ludovic.desroches
2013-09-09 15:29 ` ludovic.desroches at atmel.com
2013-09-10 7:54 ` Nicolas Ferre
2013-09-10 7:54 ` Nicolas Ferre
2013-09-26 1:46 ` Chris Ball
2013-09-26 1:46 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.