All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	xiantao.zhang@intel.com, stefan.bader@canonical.com,
	suravee.suthikulpanit@amd.com
Subject: Re: [PATCH 1/1 V3] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed
Date: Tue, 10 Sep 2013 14:02:34 +0100	[thread overview]
Message-ID: <522F186A.4020800@citrix.com> (raw)
In-Reply-To: <522F33DC02000078000F1E50@nat28.tlf.novell.com>

On 10/09/13 13:59, Jan Beulich wrote:
>>>> On 10.09.13 at 14:52, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 10/09/13 13:47, Jan Beulich wrote:
>>>>>> On 09.09.13 at 17:52, <suravee.suthikulpanit@amd.com> wrote:
>>>> +        {
>>>> +            AMD_IOMMU_DEBUG("Skipping host bridge %04x:%02x:%02x.%u (type %x)\n",
>>>> +                        pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), PCI_FUNC(bdf),
>>>> +                        pdev->type);
>>> Saying "host bridge" _and_ being in a conditional only allowing host
>>> bridges in makes printing the type redundant.
>> I specifically asked for "host bridge" here for the benefit of people
>> just reading the boot dmesg.
> And I'm not arguing about its usefulness. I'm asking for the printing
> of type to be removed.
>
> Jan
>

Oops sorry - yes.  I mis-infered your meaning.  I agree that the (type
%x) is superfluous

~Andrew

  reply	other threads:[~2013-09-10 13:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09 15:52 [PATCH 1/1 V3] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed suravee.suthikulpanit
2013-09-10 12:47 ` Jan Beulich
2013-09-10 12:52   ` Andrew Cooper
2013-09-10 12:59     ` Jan Beulich
2013-09-10 13:02       ` Andrew Cooper [this message]
2013-09-11 19:37   ` Suravee Suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522F186A.4020800@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=stefan.bader@canonical.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.