[lm-sensors] [PATCH] hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable

[lm-sensors] [PATCH] hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable

[Guenter Roeck]

This gets rid of this warning:

drivers/hwmon/hwmon-vid.c: In function 'get_via_model_d_vrm':
drivers/hwmon/hwmon-vid.c:249:27: warning: variable 'dummy' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/hwmon-vid.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
index 89cfd64..ef91b8a 100644
--- a/drivers/hwmon/hwmon-vid.c
+++ b/drivers/hwmon/hwmon-vid.c
@@ -246,7 +246,7 @@ static struct vrm_model vrm_models[] = {
  */
 static u8 get_via_model_d_vrm(void)
 {
-	unsigned int vid, brand, dummy;
+	unsigned int vid, brand, __maybe_unused dummy;
 	static const char *brands[4] = {
 		"C7-M", "C7", "Eden", "C7-D"
 	};
-- 
1.7.9.7


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable

[Jean Delvare]

Hi Guenter,

On Mon,  9 Sep 2013 03:53:21 -0700, Guenter Roeck wrote:
> This gets rid of this warning:
> 
> drivers/hwmon/hwmon-vid.c: In function 'get_via_model_d_vrm':
> drivers/hwmon/hwmon-vid.c:249:27: warning: variable 'dummy' set but not used
> [-Wunused-but-set-variable]

FWIW I no longer see this warning with gcc 4.7.2, but I remember seeing
it before.

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/hwmon/hwmon-vid.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
> index 89cfd64..ef91b8a 100644
> --- a/drivers/hwmon/hwmon-vid.c
> +++ b/drivers/hwmon/hwmon-vid.c
> @@ -246,7 +246,7 @@ static struct vrm_model vrm_models[] = {
>   */
>  static u8 get_via_model_d_vrm(void)
>  {
> -	unsigned int vid, brand, dummy;
> +	unsigned int vid, brand, __maybe_unused dummy;
>  	static const char *brands[4] = {
>  		"C7-M", "C7", "Eden", "C7-D"
>  	};

Very nice, I didn't know about this attribute.

Reviewed-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable

[Guenter Roeck]

On 09/10/2013 12:37 AM, Jean Delvare wrote:
> Hi Guenter,
>
> On Mon,  9 Sep 2013 03:53:21 -0700, Guenter Roeck wrote:
>> This gets rid of this warning:
>>
>> drivers/hwmon/hwmon-vid.c: In function 'get_via_model_d_vrm':
>> drivers/hwmon/hwmon-vid.c:249:27: warning: variable 'dummy' set but not used
>> [-Wunused-but-set-variable]
>
> FWIW I no longer see this warning with gcc 4.7.2, but I remember seeing
> it before.
>
I currently use 4.7.3. I think you may not see it anymore unless you build with W=1 (and/or C=1).

>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   drivers/hwmon/hwmon-vid.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/hwmon-vid.c b/drivers/hwmon/hwmon-vid.c
>> index 89cfd64..ef91b8a 100644
>> --- a/drivers/hwmon/hwmon-vid.c
>> +++ b/drivers/hwmon/hwmon-vid.c
>> @@ -246,7 +246,7 @@ static struct vrm_model vrm_models[] = {
>>    */
>>   static u8 get_via_model_d_vrm(void)
>>   {
>> -	unsigned int vid, brand, dummy;
>> +	unsigned int vid, brand, __maybe_unused dummy;
>>   	static const char *brands[4] = {
>>   		"C7-M", "C7", "Eden", "C7-D"
>>   	};
>
> Very nice, I didn't know about this attribute.
>
> Reviewed-by: Jean Delvare <khali@linux-fr.org>
>

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors