From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-sh@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
rob@landley.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sh_eth: add device tree support
Date: Tue, 10 Sep 2013 18:01:11 +0000 [thread overview]
Message-ID: <522F5E67.8070006@cogentembedded.com> (raw)
In-Reply-To: <522F37A7.90804@wwwdotorg.org>
Hello.
On 09/10/2013 07:15 PM, Stephen Warren wrote:
>>> Do you need any clocks properties, IP block reset signals, power domains?
>> Currently not.
> What does "currently" mean? Does that mean that the Linux driver simply
> doesn't touch those entities at present?
There's Ether clock but the driver doesn't manipulate it directly,
assumingly it does this thru the runtime PM interface. As for the others, I
simply don't know.
> If so, that's not enough to say
> that those entities should not be described in the DT binding. We should
> strive to make the binding completely describe all aspects of the HW,
> irrespective of whether a particular driver happens to use that
> information at present.
There's no DT representation for the clocks in SH-Mobile subarch yet.
The same applies to the other entities you mentioned.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-sh@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
rob@landley.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sh_eth: add device tree support
Date: Tue, 10 Sep 2013 22:01:11 +0400 [thread overview]
Message-ID: <522F5E67.8070006@cogentembedded.com> (raw)
In-Reply-To: <522F37A7.90804@wwwdotorg.org>
Hello.
On 09/10/2013 07:15 PM, Stephen Warren wrote:
>>> Do you need any clocks properties, IP block reset signals, power domains?
>> Currently not.
> What does "currently" mean? Does that mean that the Linux driver simply
> doesn't touch those entities at present?
There's Ether clock but the driver doesn't manipulate it directly,
assumingly it does this thru the runtime PM interface. As for the others, I
simply don't know.
> If so, that's not enough to say
> that those entities should not be described in the DT binding. We should
> strive to make the binding completely describe all aspects of the HW,
> irrespective of whether a particular driver happens to use that
> information at present.
There's no DT representation for the clocks in SH-Mobile subarch yet.
The same applies to the other entities you mentioned.
WBR, Sergei
next prev parent reply other threads:[~2013-09-10 18:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 23:43 [PATCH v2 2/2] sh_eth: add device tree support Sergei Shtylyov
2013-09-06 23:43 ` Sergei Shtylyov
2013-09-09 21:02 ` Stephen Warren
2013-09-09 21:02 ` Stephen Warren
2013-09-10 14:39 ` Sergei Shtylyov
2013-09-10 14:39 ` Sergei Shtylyov
2013-09-10 15:15 ` Stephen Warren
2013-09-10 15:15 ` Stephen Warren
2013-09-10 18:01 ` Sergei Shtylyov [this message]
2013-09-10 18:01 ` Sergei Shtylyov
2013-09-10 20:07 ` Stephen Warren
2013-09-10 20:07 ` Stephen Warren
2013-09-10 21:48 ` Sergei Shtylyov
2013-09-10 21:48 ` Sergei Shtylyov
2013-09-10 22:21 ` Stephen Warren
2013-09-10 22:21 ` Stephen Warren
2013-10-16 22:41 ` Sergei Shtylyov
2013-10-16 22:41 ` Sergei Shtylyov
2013-10-17 16:41 ` Mark Rutland
2013-10-17 16:41 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F5E67.8070006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.