* [PATCH 1/3] extcon: adc-jack: use dev_get_platdata()
2013-09-11 2:21 [PATCH 0/3] extcon: use dev_get_platdata() Jingoo Han
@ 2013-09-11 2:23 ` Jingoo Han
2013-09-11 2:26 ` [PATCH 2/3] extcon: gpio: " Jingoo Han
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-11 2:23 UTC (permalink / raw)
To: 'Chanwoo Choi'
Cc: 'MyungJoo Ham', linux-kernel, 'Jingoo Han',
'Anish Kumar', 'Lars-Peter Clausen'
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/extcon/extcon-adc-jack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
index 5985807..c0e0e20 100644
--- a/drivers/extcon/extcon-adc-jack.c
+++ b/drivers/extcon/extcon-adc-jack.c
@@ -95,7 +95,7 @@ static irqreturn_t adc_jack_irq_thread(int irq, void *_data)
static int adc_jack_probe(struct platform_device *pdev)
{
struct adc_jack_data *data;
- struct adc_jack_pdata *pdata = pdev->dev.platform_data;
+ struct adc_jack_pdata *pdata = dev_get_platdata(&pdev->dev);
int i, err = 0;
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] extcon: gpio: use dev_get_platdata()
2013-09-11 2:21 [PATCH 0/3] extcon: use dev_get_platdata() Jingoo Han
2013-09-11 2:23 ` [PATCH 1/3] extcon: adc-jack: " Jingoo Han
@ 2013-09-11 2:26 ` Jingoo Han
2013-09-11 2:27 ` [PATCH 3/3] extcon: palmas: " Jingoo Han
2013-09-11 2:36 ` [PATCH 0/3] extcon: " Chanwoo Choi
3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-11 2:26 UTC (permalink / raw)
To: 'Chanwoo Choi'
Cc: 'MyungJoo Ham', linux-kernel, 'Jingoo Han',
'Mike Lockwood'
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/extcon/extcon-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index f874c30..c4d5a19 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -78,7 +78,7 @@ static ssize_t extcon_gpio_print_state(struct extcon_dev *edev, char *buf)
static int gpio_extcon_probe(struct platform_device *pdev)
{
- struct gpio_extcon_platform_data *pdata = pdev->dev.platform_data;
+ struct gpio_extcon_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct gpio_extcon_data *extcon_data;
int ret = 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] extcon: palmas: use dev_get_platdata()
2013-09-11 2:21 [PATCH 0/3] extcon: use dev_get_platdata() Jingoo Han
2013-09-11 2:23 ` [PATCH 1/3] extcon: adc-jack: " Jingoo Han
2013-09-11 2:26 ` [PATCH 2/3] extcon: gpio: " Jingoo Han
@ 2013-09-11 2:27 ` Jingoo Han
2013-09-11 2:36 ` [PATCH 0/3] extcon: " Chanwoo Choi
3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-11 2:27 UTC (permalink / raw)
To: 'Chanwoo Choi'
Cc: 'MyungJoo Ham', linux-kernel, 'Jingoo Han',
'Laxman Dewangan', 'Graeme Gregory'
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/extcon/extcon-palmas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 89fdd05..0c2fb68 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -135,7 +135,7 @@ static void palmas_enable_irq(struct palmas_usb *palmas_usb)
static int palmas_usb_probe(struct platform_device *pdev)
{
struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
- struct palmas_usb_platform_data *pdata = pdev->dev.platform_data;
+ struct palmas_usb_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct device_node *node = pdev->dev.of_node;
struct palmas_usb *palmas_usb;
int status;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/3] extcon: use dev_get_platdata()
2013-09-11 2:21 [PATCH 0/3] extcon: use dev_get_platdata() Jingoo Han
` (2 preceding siblings ...)
2013-09-11 2:27 ` [PATCH 3/3] extcon: palmas: " Jingoo Han
@ 2013-09-11 2:36 ` Chanwoo Choi
3 siblings, 0 replies; 5+ messages in thread
From: Chanwoo Choi @ 2013-09-11 2:36 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'MyungJoo Ham', linux-kernel
Hi Jingoo,
I prefer to consolidate this patchset as one patch because of simliar moditication.
Thanks,
Chanwoo Choi
On 09/11/2013 11:21 AM, Jingoo Han wrote:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly. This is a cosmetic change
> to make the code simpler and enhance the readability.
>
> ---
> drivers/extcon/extcon-adc-jack.c | 2 +-
> drivers/extcon/extcon-gpio.c | 2 +-
> drivers/extcon/extcon-palmas.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 5+ messages in thread