From: Clemens Ladisch <clemens@ladisch.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata()
Date: Thu, 12 Sep 2013 08:19:45 +0000 [thread overview]
Message-ID: <52317921.30406@ladisch.de> (raw)
In-Reply-To: <001801ceaf83$d5633bb0$8029b310$%han@samsung.com>
Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> drivers/hwmon/k10temp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index e633856..d65f3fd 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -202,7 +202,6 @@ static void k10temp_remove(struct pci_dev *pdev)
> &sensor_dev_attr_temp1_crit.dev_attr);
> device_remove_file(&pdev->dev,
> &sensor_dev_attr_temp1_crit_hyst.dev_attr);
> - pci_set_drvdata(pdev, NULL);
> }
>
> static DEFINE_PCI_DEVICE_TABLE(k10temp_id_table) = {
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-09-12 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:46 [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12 8:19 ` Clemens Ladisch [this message]
2013-09-12 15:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52317921.30406@ladisch.de \
--to=clemens@ladisch.de \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.