* [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata()
@ 2013-09-12 6:46 Jingoo Han
2013-09-12 8:19 ` Clemens Ladisch
2013-09-12 15:18 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-12 6:46 UTC (permalink / raw)
To: lm-sensors
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/hwmon/k10temp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index e633856..d65f3fd 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -202,7 +202,6 @@ static void k10temp_remove(struct pci_dev *pdev)
&sensor_dev_attr_temp1_crit.dev_attr);
device_remove_file(&pdev->dev,
&sensor_dev_attr_temp1_crit_hyst.dev_attr);
- pci_set_drvdata(pdev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(k10temp_id_table) = {
--
1.7.10.4
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata()
2013-09-12 6:46 [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-09-12 8:19 ` Clemens Ladisch
2013-09-12 15:18 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Clemens Ladisch @ 2013-09-12 8:19 UTC (permalink / raw)
To: lm-sensors
Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> drivers/hwmon/k10temp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index e633856..d65f3fd 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -202,7 +202,6 @@ static void k10temp_remove(struct pci_dev *pdev)
> &sensor_dev_attr_temp1_crit.dev_attr);
> device_remove_file(&pdev->dev,
> &sensor_dev_attr_temp1_crit_hyst.dev_attr);
> - pci_set_drvdata(pdev, NULL);
> }
>
> static DEFINE_PCI_DEVICE_TABLE(k10temp_id_table) = {
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata()
2013-09-12 6:46 [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12 8:19 ` Clemens Ladisch
@ 2013-09-12 15:18 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-09-12 15:18 UTC (permalink / raw)
To: lm-sensors
On Thu, Sep 12, 2013 at 03:46:39PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-12 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 6:46 [lm-sensors] [PATCH] hwmon: (k10temp) remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12 8:19 ` Clemens Ladisch
2013-09-12 15:18 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.