All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] mx6sabresd: Reset counter to prevent error message
Date: Thu, 12 Sep 2013 12:17:22 +0200	[thread overview]
Message-ID: <523194B2.5030104@denx.de> (raw)
In-Reply-To: <1378934070-11721-2-git-send-email-festevam@gmail.com>

Hi Fabio,

On 11/09/2013 23:14, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If a HDMI cable is not connected, the following message is seen on boot:
> 
> CPU:   Freescale i.MX6Q rev1.1 at 792 MHz                                       
> Reset cause: POR                                                                
> Board: MX6-SabreSD                                                              
> DRAM:  1 GiB                                                                    
> MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2                                    
> No panel detected: default to HDMI                                              
> unsupported panel HDMI 
> 
> Reset the 'i' variable to fix the 'unsupported panel' message.
> 
> This follows the same idea of commit 47ac53d7ae (imx: nitrogen6x/mx6qsabrelite: 
> Fix bug in board_video_skip).
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index 0f91fe2..61fe67c 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -322,6 +322,7 @@ int board_video_skip(void)
>  		if (!panel) {
>  			panel = displays[0].mode.name;
>  			printf("No panel detected: default to %s\n", panel);
> +			i = 0;
>  		}

Robert sents the same fix for nitrogen6x, and it was integrated. The two
functions board_video_skip() are exactly the same. What about to
factorize the code putting it maybe in imx-common ?

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-09-12 10:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 21:14 [U-Boot] [PATCH v2 1/2] mx6sabresd: Avoid hang when HDMI cable is not connected Fabio Estevam
2013-09-11 21:14 ` [U-Boot] [PATCH v2 2/2] mx6sabresd: Reset counter to prevent error message Fabio Estevam
2013-09-12 10:17   ` Stefano Babic [this message]
2013-09-12 15:28     ` Eric Nelson
2013-09-20 16:03   ` Stefano Babic
2013-09-12  9:47 ` [U-Boot] [PATCH v2 1/2] mx6sabresd: Avoid hang when HDMI cable is not connected Stefano Babic
2013-09-12 15:02   ` Eric Nelson
2013-09-13  8:16     ` Stefano Babic
2013-09-13 13:58       ` Fabio Estevam
2013-09-13 14:19         ` Stefano Babic
2013-09-13 14:51         ` Eric Nelson
2013-09-13 18:11           ` Fabio Estevam
2013-09-13 18:34             ` Eric Nelson
2013-09-20 16:03 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523194B2.5030104@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.