From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] mx6sabresd: Avoid hang when HDMI cable is not connected
Date: Thu, 12 Sep 2013 08:02:34 -0700 [thread overview]
Message-ID: <5231D78A.5000002@boundarydevices.com> (raw)
In-Reply-To: <52318D9E.1@denx.de>
Thanks Stefano,
On 09/12/2013 02:47 AM, Stefano Babic wrote:
> Hi Fabio,
>
> CC to Eric and Troy.
>
> On 11/09/2013 23:14, Fabio Estevam wrote:
>
>> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
>> index c832bd9..0f91fe2 100644
>> --- a/board/freescale/mx6sabresd/mx6sabresd.c
>> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
>> @@ -313,7 +313,7 @@ int board_video_skip(void)
>> if (!panel) {
>> for (i = 0; i < ARRAY_SIZE(displays); i++) {
>> struct display_info_t const *dev = displays+i;
>> - if (dev->detect(dev)) {
>> + if (dev->detect && dev->detect(dev)) {
>
> The same should happen on the Nitrogen board. Should this fix extended
> to the other boards using hdmi ?
>
This isn't needed yet in the stock (main-line) code base, since
we haven't added any panels without detection.
We do have a form this patch and a lot of panels in our local tree
on Github, but wanted to avoid unnecessary noise on the list
because we've integrated a dozen or so panels and the existing
structure really doesn't scale.
We had a separate discussion regarding treating the displays
as data (environment), but have stalled somewhat on that front.
The current device-tree code for i.MX6 uses mode strings instead
of the detailed timing data that's really needed for a proper
solution.
Regards,
Eric
next prev parent reply other threads:[~2013-09-12 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 21:14 [U-Boot] [PATCH v2 1/2] mx6sabresd: Avoid hang when HDMI cable is not connected Fabio Estevam
2013-09-11 21:14 ` [U-Boot] [PATCH v2 2/2] mx6sabresd: Reset counter to prevent error message Fabio Estevam
2013-09-12 10:17 ` Stefano Babic
2013-09-12 15:28 ` Eric Nelson
2013-09-20 16:03 ` Stefano Babic
2013-09-12 9:47 ` [U-Boot] [PATCH v2 1/2] mx6sabresd: Avoid hang when HDMI cable is not connected Stefano Babic
2013-09-12 15:02 ` Eric Nelson [this message]
2013-09-13 8:16 ` Stefano Babic
2013-09-13 13:58 ` Fabio Estevam
2013-09-13 14:19 ` Stefano Babic
2013-09-13 14:51 ` Eric Nelson
2013-09-13 18:11 ` Fabio Estevam
2013-09-13 18:34 ` Eric Nelson
2013-09-20 16:03 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5231D78A.5000002@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.