* [Qemu-trivial] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
@ 2013-09-05 10:54 ` Michal Privoznik
0 siblings, 0 replies; 6+ messages in thread
From: Michal Privoznik @ 2013-09-05 10:54 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
previous detection if the macro has been already defined, e.g.
by environment, or is just enabled by compiler by default.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
The issue still happens thus the patch is still valid.
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e989609..24e5b00 100755
--- a/configure
+++ b/configure
@@ -3419,7 +3419,7 @@ if test "$gcov" = "yes" ; then
CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
elif test "$debug" = "no" ; then
- CFLAGS="-O2 -D_FORTIFY_SOURCE=2 $CFLAGS"
+ CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
fi
--
1.8.1.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
@ 2013-09-05 10:54 ` Michal Privoznik
0 siblings, 0 replies; 6+ messages in thread
From: Michal Privoznik @ 2013-09-05 10:54 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
previous detection if the macro has been already defined, e.g.
by environment, or is just enabled by compiler by default.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
The issue still happens thus the patch is still valid.
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e989609..24e5b00 100755
--- a/configure
+++ b/configure
@@ -3419,7 +3419,7 @@ if test "$gcov" = "yes" ; then
CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
elif test "$debug" = "no" ; then
- CFLAGS="-O2 -D_FORTIFY_SOURCE=2 $CFLAGS"
+ CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
fi
--
1.8.1.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
2013-09-05 10:54 ` [Qemu-devel] " Michal Privoznik
@ 2013-09-05 10:59 ` Peter Maydell
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2013-09-05 10:59 UTC (permalink / raw)
To: Michal Privoznik; +Cc: QEMU Trivial, QEMU Developers
On 5 September 2013 11:54, Michal Privoznik <mprivozn@redhat.com> wrote:
> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
> previous detection if the macro has been already defined, e.g.
> by environment, or is just enabled by compiler by default.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
@ 2013-09-05 10:59 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2013-09-05 10:59 UTC (permalink / raw)
To: Michal Privoznik; +Cc: QEMU Trivial, QEMU Developers
On 5 September 2013 11:54, Michal Privoznik <mprivozn@redhat.com> wrote:
> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
> previous detection if the macro has been already defined, e.g.
> by environment, or is just enabled by compiler by default.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
2013-09-05 10:54 ` [Qemu-devel] " Michal Privoznik
@ 2013-09-12 18:51 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-09-12 18:51 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-trivial, qemu-devel
05.09.2013 14:54, Michal Privoznik wrote:
> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
> previous detection if the macro has been already defined, e.g.
> by environment, or is just enabled by compiler by default.
Thanks, applied to the trivial-patches queue
(combined with the similar patch by Jan Vesely).
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it
@ 2013-09-12 18:51 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-09-12 18:51 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-trivial, qemu-devel
05.09.2013 14:54, Michal Privoznik wrote:
> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any
> previous detection if the macro has been already defined, e.g.
> by environment, or is just enabled by compiler by default.
Thanks, applied to the trivial-patches queue
(combined with the similar patch by Jan Vesely).
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-12 18:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 10:54 [Qemu-trivial] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it Michal Privoznik
2013-09-05 10:54 ` [Qemu-devel] " Michal Privoznik
2013-09-05 10:59 ` [Qemu-trivial] " Peter Maydell
2013-09-05 10:59 ` Peter Maydell
2013-09-12 18:51 ` [Qemu-trivial] " Michael Tokarev
2013-09-12 18:51 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.